716258 - Use Services.prefs instead of gPrefService / preferences-service, in Firefox tests

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Michael Kohler [:mkohler]]

According to Bug 592653 we should use Services.prefs instead of gPrefService in tests. This bug is only for the browser directory within mozilla-central (trying to split the different parts of mozilla-central, otherwise it gets pretty confusing).

http://mxr.mozilla.org/mozilla-central/ident?i=gPrefService&tree=mozilla-central&filter=browser

Comment 1

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/mozilla-central/search?string=gPrefService&case=1&find=%2Fbrowser%2F.*%2Ftest
"Found 191 matching lines in 54 files"

http://mxr.mozilla.org/mozilla-central/search?string=preferences-service&case=1&find=%2Fbrowser%2F.*%2Ftest
"Found 28 matching lines in 23 files"

Comment 2

[Michael Kohler [:mkohler]]

Attachment: SessionStore Patch v1

Comment 3

[Michael Kohler [:mkohler]]

Attachment: Misc within /browser/

Comment 4

[Michael Kohler [:mkohler]]

Attachment: Places / Tabview v1

Comment 5

[Dão Gottwald [:dao]]

(In reply to Michael Kohler [:michaelkohler] from comment #0)
> According to Bug 592653 we should use Services.prefs instead of gPrefService
> in tests. This bug is only for the browser directory within mozilla-central

SeaMonkey won't run any of these tests. They are Firefox-specific.

Comment 6

[Michael Kohler [:mkohler]]

Attachment: PrivateBrowsing v1

Comment 7

[Michael Kohler [:mkohler]]

Attachment: Content v1

Comment 8

[:Gavin Sharp [email: [e-mail]]]

I don't think there's much value in making these changes. We're not going to get rid of gPrefService any time soon, so there's no real reason to remove references to it.

Comment 9

[Michael Kohler [:mkohler]]

(In reply to Gavin Sharp (use [e-mail] for email) from comment #8)
> I don't think there's much value in making these changes. We're not going to
> get rid of gPrefService any time soon, so there's no real reason to remove
> references to it.

sure, but it won't hurt,  will it?

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Yes, it will hurt - it will take up reviewers time, and it risks causing bugs :)