Last Comment Bug 716333 - get rid of WithConversion (xpconnect part)
: get rid of WithConversion (xpconnect part)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
Depends on:
Blocks: 113234
  Show dependency treegraph
 
Reported: 2012-01-08 01:26 PST by Makoto Kato [:m_kato]
Modified: 2012-03-26 11:28 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (3.15 KB, patch)
2012-01-08 01:26 PST, Makoto Kato [:m_kato]
no flags Details | Diff | Review
fix (3.36 KB, patch)
2012-03-21 07:31 PDT, Makoto Kato [:m_kato]
bobbyholley: review+
Details | Diff | Review

Description Makoto Kato [:m_kato] 2012-01-08 01:26:09 PST
Created attachment 586769 [details] [diff] [review]
fix
Comment 1 Bobby Holley (busy) 2012-01-10 14:15:26 PST
char*s are black boxes to the JS engine, so whether this patch is correct or not depends on where these strings come from, and whether those strings are UTF8, latin1, or something else. Have you done this analysis? Where do each of these strings originate?
Comment 2 Makoto Kato [:m_kato] 2012-01-16 04:29:08 PST
(In reply to Bobby Holley (:bholley) from comment #1)
> char*s are black boxes to the JS engine, so whether this patch is correct or
> not depends on where these strings come from, and whether those strings are
> UTF8, latin1, or something else. Have you done this analysis? Where do each
> of these strings originate?

Don't this return UTF-8 even if localized version?  If so, I should use NS_ConvertASCIItoUTF16 instead of.
Comment 3 Bobby Holley (busy) 2012-01-16 17:23:58 PST
(In reply to Makoto Kato from comment #2)
> Don't this return UTF-8 even if localized version?  If so, I should use
> NS_ConvertASCIItoUTF16 instead of.

I'm not quite sure what you mean. The issue here is that we need to know the original encoding of these strings in order to determine whether to use NS_ConvertUTF8toUTF16 or NS_ConvertASCIItoUTF16. The JS doesn't specify the encoding for JSErrorReport::filename, for example, so we have to track down where that comes from.
Comment 4 Bobby Holley (busy) 2012-02-04 16:35:08 PST
Comment on attachment 586769 [details] [diff] [review]
fix

Cancelling review until comment 3 is sorted out.
Comment 5 Makoto Kato [:m_kato] 2012-03-21 07:31:11 PDT
Created attachment 607944 [details] [diff] [review]
fix
Comment 7 Matt Brubeck (:mbrubeck) 2012-03-26 11:28:05 PDT
https://hg.mozilla.org/mozilla-central/rev/28cc6bf92f1f

Note You need to log in before you can comment on or make changes to this bug.