Closed
Bug 716333
Opened 13 years ago
Closed 12 years ago
get rid of WithConversion (xpconnect part)
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file, 1 obsolete file)
3.36 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #586769 -
Flags: review?(bobbyholley+bmo)
Comment 1•12 years ago
|
||
char*s are black boxes to the JS engine, so whether this patch is correct or not depends on where these strings come from, and whether those strings are UTF8, latin1, or something else. Have you done this analysis? Where do each of these strings originate?
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #1) > char*s are black boxes to the JS engine, so whether this patch is correct or > not depends on where these strings come from, and whether those strings are > UTF8, latin1, or something else. Have you done this analysis? Where do each > of these strings originate? Don't this return UTF-8 even if localized version? If so, I should use NS_ConvertASCIItoUTF16 instead of.
Comment 3•12 years ago
|
||
(In reply to Makoto Kato from comment #2) > Don't this return UTF-8 even if localized version? If so, I should use > NS_ConvertASCIItoUTF16 instead of. I'm not quite sure what you mean. The issue here is that we need to know the original encoding of these strings in order to determine whether to use NS_ConvertUTF8toUTF16 or NS_ConvertASCIItoUTF16. The JS doesn't specify the encoding for JSErrorReport::filename, for example, so we have to track down where that comes from.
Comment 4•12 years ago
|
||
Comment on attachment 586769 [details] [diff] [review] fix Cancelling review until comment 3 is sorted out.
Attachment #586769 -
Flags: review?(bobbyholley+bmo)
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #586769 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #607944 -
Flags: review?(bobbyholley+bmo)
Updated•12 years ago
|
Attachment #607944 -
Flags: review?(bobbyholley+bmo) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/28cc6bf92f1f
Whiteboard: [inbound]
Updated•12 years ago
|
Whiteboard: [inbound]
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/28cc6bf92f1f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•