get rid of WithConversion (xpconnect part)

RESOLVED FIXED in mozilla14

Status

()

Core
XPConnect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 586769 [details] [diff] [review]
fix
Attachment #586769 - Flags: review?(bobbyholley+bmo)
char*s are black boxes to the JS engine, so whether this patch is correct or not depends on where these strings come from, and whether those strings are UTF8, latin1, or something else. Have you done this analysis? Where do each of these strings originate?
(Assignee)

Comment 2

5 years ago
(In reply to Bobby Holley (:bholley) from comment #1)
> char*s are black boxes to the JS engine, so whether this patch is correct or
> not depends on where these strings come from, and whether those strings are
> UTF8, latin1, or something else. Have you done this analysis? Where do each
> of these strings originate?

Don't this return UTF-8 even if localized version?  If so, I should use NS_ConvertASCIItoUTF16 instead of.
(In reply to Makoto Kato from comment #2)
> Don't this return UTF-8 even if localized version?  If so, I should use
> NS_ConvertASCIItoUTF16 instead of.

I'm not quite sure what you mean. The issue here is that we need to know the original encoding of these strings in order to determine whether to use NS_ConvertUTF8toUTF16 or NS_ConvertASCIItoUTF16. The JS doesn't specify the encoding for JSErrorReport::filename, for example, so we have to track down where that comes from.
Comment on attachment 586769 [details] [diff] [review]
fix

Cancelling review until comment 3 is sorted out.
Attachment #586769 - Flags: review?(bobbyholley+bmo)
(Assignee)

Comment 5

5 years ago
Created attachment 607944 [details] [diff] [review]
fix
Attachment #586769 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #607944 - Flags: review?(bobbyholley+bmo)
Attachment #607944 - Flags: review?(bobbyholley+bmo) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/28cc6bf92f1f
Whiteboard: [inbound]

Updated

5 years ago
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/28cc6bf92f1f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.