716354 - freetype2 detection doesn't consider cross-compiling

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

Actually, although we use freetype2.m4, this doesn't consider cross-compiling environment.  We should use pkg-config instead of.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Mike Hommey [:glandium]]

How exactly does freetype2.m4 fail with cross-compiling? AFAICS it should work, skipping the compilation check, which using pkg-config does even when not cross-compiling.

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Mike Hommey [:glandium] from comment #2)
> How exactly does freetype2.m4 fail with cross-compiling? AFAICS it should
> work, skipping the compilation check, which using pkg-config does even when
> not cross-compiling.

when using apt-cross, freetype-config for taget isn't installed.  So it is no way to get freetype-config for target.

Comment 4

[Mike Hommey [:glandium]]

Shouldn't it be there, though?

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 587611 [details] [diff] [review]
fix

My fear is that we'd be lacking the extra tests from freetype2.m4, but I think it's fine anyways.

Comment 6

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3875882a5ff4

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/3875882a5ff4