freetype2 detection doesn't consider cross-compiling

RESOLVED FIXED in mozilla14

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla14
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Actually, although we use freetype2.m4, this doesn't consider cross-compiling environment.  We should use pkg-config instead of.
(Assignee)

Comment 1

5 years ago
Created attachment 587611 [details] [diff] [review]
fix
Attachment #587611 - Flags: review?(mh+mozilla)
How exactly does freetype2.m4 fail with cross-compiling? AFAICS it should work, skipping the compilation check, which using pkg-config does even when not cross-compiling.
(Assignee)

Comment 3

5 years ago
(In reply to Mike Hommey [:glandium] from comment #2)
> How exactly does freetype2.m4 fail with cross-compiling? AFAICS it should
> work, skipping the compilation check, which using pkg-config does even when
> not cross-compiling.

when using apt-cross, freetype-config for taget isn't installed.  So it is no way to get freetype-config for target.
Shouldn't it be there, though?
Comment on attachment 587611 [details] [diff] [review]
fix

My fear is that we'd be lacking the extra tests from freetype2.m4, but I think it's fine anyways.
Attachment #587611 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/3875882a5ff4
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/3875882a5ff4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla14
Blocks: 743441
You need to log in before you can comment on or make changes to this bug.