Last Comment Bug 716354 - freetype2 detection doesn't consider cross-compiling
: freetype2 detection doesn't consider cross-compiling
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
Depends on:
Blocks: 743441
  Show dependency treegraph
 
Reported: 2012-01-08 04:32 PST by Makoto Kato [:m_kato]
Modified: 2012-04-07 05:30 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (6.66 KB, patch)
2012-01-11 00:03 PST, Makoto Kato [:m_kato]
mh+mozilla: review+
Details | Diff | Review

Description Makoto Kato [:m_kato] 2012-01-08 04:32:30 PST
Actually, although we use freetype2.m4, this doesn't consider cross-compiling environment.  We should use pkg-config instead of.
Comment 1 Makoto Kato [:m_kato] 2012-01-11 00:03:36 PST
Created attachment 587611 [details] [diff] [review]
fix
Comment 2 Mike Hommey [:glandium] 2012-01-11 00:19:38 PST
How exactly does freetype2.m4 fail with cross-compiling? AFAICS it should work, skipping the compilation check, which using pkg-config does even when not cross-compiling.
Comment 3 Makoto Kato [:m_kato] 2012-01-11 00:24:24 PST
(In reply to Mike Hommey [:glandium] from comment #2)
> How exactly does freetype2.m4 fail with cross-compiling? AFAICS it should
> work, skipping the compilation check, which using pkg-config does even when
> not cross-compiling.

when using apt-cross, freetype-config for taget isn't installed.  So it is no way to get freetype-config for target.
Comment 4 Mike Hommey [:glandium] 2012-01-11 00:39:38 PST
Shouldn't it be there, though?
Comment 5 Mike Hommey [:glandium] 2012-01-30 07:48:34 PST
Comment on attachment 587611 [details] [diff] [review]
fix

My fear is that we'd be lacking the extra tests from freetype2.m4, but I think it's fine anyways.
Comment 7 Matt Brubeck (:mbrubeck) 2012-04-06 11:48:35 PDT
https://hg.mozilla.org/mozilla-central/rev/3875882a5ff4

Note You need to log in before you can comment on or make changes to this bug.