Closed
Bug 716532
Opened 13 years ago
Closed 13 years ago
[New Tab Page] Remove "site strip" at the top and re-style buttons
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
(Keywords: uiwanted)
Attachments
(3 files)
736.63 KB,
image/png
|
Details | |
7.00 KB,
application/zip
|
Details | |
10.84 KB,
patch
|
limi
:
ui-review-
|
Details | Diff | Splinter Review |
The black bar at the top that contains the "pin" and "remove" buttons should be removed. The buttons get a slight re-styling so that they can be stand-alone.
Comment 1•13 years ago
|
||
Agree here. I believe this was a change Boriss was going to make?
Assignee | ||
Comment 2•13 years ago
|
||
Yes, Limi told me this so I figured Boriss knows about it :)
Comment 3•13 years ago
|
||
Instead of a bar, let’s show only the two relevant icons in the same semi-transparent black at the bottom of the thumbnails. The attached icons are all black, but at 50% opacity on thumbnail mouseover, 70% opacity on icon mouseover, and 90% opacity on click. When the pin is activated, it should remain in 70% opacity.
It’s true that on some dark pages it will be harder to see the shapes. But the alternative is a multi-colored icon which looks unlike the overall style of the page or a way to determine the darkness of the thumbnail and adjust accordingly - an option both more complicated and less consistent. Considering the icons are the same on every thumbnail, simply having the 50% black opacity takes care of most cases and certainly doesn’t hamper a user who uses the icons and thus knows they are there.
Comment 4•13 years ago
|
||
Updated•13 years ago
|
Assignee: jboriss → ttaubert
Assignee | ||
Comment 5•13 years ago
|
||
Assignee | ||
Comment 6•13 years ago
|
||
Comment on attachment 594156 [details] [diff] [review]
patch v1
I figured that flagging a screenshot for review doesn't really make sense here. This patch is contained in the latest UX nightlies and waits for ux-review!
Attachment #594156 -
Flags: ui-review?(ux-review)
Comment 7•13 years ago
|
||
On the latest UX build, the default, pinned and hovered states do not look very different. Also after pinning/unpinning a thumbnail and moving the mouse away, the pin icon does not disappear until another thumbnail is clicked. Is this by design?
Comment 8•13 years ago
|
||
Comment on attachment 594156 [details] [diff] [review]
patch v1
Review of attachment 594156 [details] [diff] [review]:
-----------------------------------------------------------------
The difference between hovered states is not sufficient. How about we put a dark gray box around the elements when hovered, and keep the box when pinned? (sorry if this isn't a clear explanation, I'll talk to Boriss about it. :)
Attachment #594156 -
Flags: ui-review?(ux-review) → ui-review-
Assignee | ||
Comment 9•13 years ago
|
||
Waiting for new mockups and/or style directives.
Keywords: uiwanted
Comment 10•13 years ago
|
||
Assignee | ||
Comment 11•13 years ago
|
||
Fixed by bug 729878.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•