716538 - [New Tab Page] Set to enabled by default on Nightly

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

We're gonna land this feature on trunk but pref'ed off. This bug has all the dependencies and the patch needed to enable it for Nightly users.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

This patch enables the New Tab Page on Nightly, only. Keeps it disabled on Official, Unofficial and Aurora.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Clearing unresolved dependencies. We're not going to block on this to get early feedback on the New Tab Page.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 586991 [details] [diff] [review]
patch v1

Review of attachment 586991 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks for requesting review :)

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/ff95d5991457

Comment 6

[Dão Gottwald [:dao]]

Why does this patch mess with browser/branding/{aurora,official,unofficial}/pref/firefox-branding.js? Can't browser/branding/nightly/pref/firefox-branding.js override browser/app/profile/firefox.js?

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Backed out:

https://hg.mozilla.org/integration/fx-team/rev/5421a03367b8

Going to upload a new patch for tomorrow which just flips the pref for everyone and we're ready to back it out if it's not ready for Aurora in six weeks.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/29c4463e6a2e

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/29c4463e6a2e

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 593358 [details] [diff] [review]
patch v2

[Approval Request Comment]
Regression caused by (bug #): New feature, no regression.
User impact if declined: No New Tab Page :(
Testing completed (on m-c, etc.): 1-2 weeks baking time on Nightly.
String changes made by this patch: None.

We want to collect user feedback from more users. The New Tab Page should be enabled for Aurora 12, but will be disabled for Beta in ~4 weeks.

Comment 12

[Chris Lee [:clee]]

The approval from drivers is to pref this on for 1 wk starting today and we'll plan to pref this back off by next Thurs, 2/16.  

Can you file a separate bug to pref this back off next week?  Thanks!

Comment 13

[Alex Keybl [:akeybl]]

Comment on attachment 593358 [details] [diff] [review]
patch v2

[Triage Comment]
Approving for Aurora 12 with the understanding that this will be pref'd off a week after landing.

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ba0287a8920f

Filed bug 725873 to pref the New Tab Page off again after a week.

Comment 15

[u279076]

Verified fixed in Firefox 12.0b3.