Last Comment Bug 716538 - [New Tab Page] Set to enabled by default on Nightly
: [New Tab Page] Set to enabled by default on Nightly
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- normal with 2 votes (vote)
: Firefox 13
Assigned To: Tim Taubert [:ttaubert]
: Dão Gottwald [:dao]
: 722643 (view as bug list)
Depends on: 985521 455553 715710 716855 717109 717110 717492 721087 723832 725873
  Show dependency treegraph
Reported: 2012-01-09 07:07 PST by Tim Taubert [:ttaubert]
Modified: 2014-03-27 09:58 PDT (History)
21 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch v1 (4.53 KB, patch)
2012-01-09 07:26 PST, Tim Taubert [:ttaubert]
jaws: review+
Details | Diff | Splinter Review
patch v2 (882 bytes, patch)
2012-02-01 02:20 PST, Tim Taubert [:ttaubert]
jaws: review+
akeybl: approval‑mozilla‑aurora+
Details | Diff | Splinter Review

Description Tim Taubert [:ttaubert] 2012-01-09 07:07:44 PST
We're gonna land this feature on trunk but pref'ed off. This bug has all the dependencies and the patch needed to enable it for Nightly users.
Comment 1 Tim Taubert [:ttaubert] 2012-01-09 07:26:17 PST
Created attachment 586991 [details] [diff] [review]
patch v1

This patch enables the New Tab Page on Nightly, only. Keeps it disabled on Official, Unofficial and Aurora.
Comment 2 Tim Taubert [:ttaubert] 2012-01-31 01:43:29 PST
*** Bug 722643 has been marked as a duplicate of this bug. ***
Comment 3 Tim Taubert [:ttaubert] 2012-01-31 01:46:21 PST
Clearing unresolved dependencies. We're not going to block on this to get early feedback on the New Tab Page.
Comment 4 Jared Wein [:jaws] (please needinfo? me) 2012-01-31 02:01:53 PST
Comment on attachment 586991 [details] [diff] [review]
patch v1

Review of attachment 586991 [details] [diff] [review]:

Looks good. Thanks for requesting review :)
Comment 5 Tim Taubert [:ttaubert] 2012-01-31 02:17:30 PST
Comment 6 Dão Gottwald [:dao] 2012-01-31 03:08:03 PST
Why does this patch mess with browser/branding/{aurora,official,unofficial}/pref/firefox-branding.js? Can't browser/branding/nightly/pref/firefox-branding.js override browser/app/profile/firefox.js?
Comment 7 Tim Taubert [:ttaubert] 2012-01-31 03:31:26 PST
Backed out:

Going to upload a new patch for tomorrow which just flips the pref for everyone and we're ready to back it out if it's not ready for Aurora in six weeks.
Comment 8 Tim Taubert [:ttaubert] 2012-02-01 02:20:47 PST
Created attachment 593358 [details] [diff] [review]
patch v2
Comment 9 Tim Taubert [:ttaubert] 2012-02-01 02:53:48 PST
Comment 10 Tim Taubert [:ttaubert] 2012-02-02 01:09:28 PST
Comment 11 Tim Taubert [:ttaubert] 2012-02-09 13:29:00 PST
Comment on attachment 593358 [details] [diff] [review]
patch v2

[Approval Request Comment]
Regression caused by (bug #): New feature, no regression.
User impact if declined: No New Tab Page :(
Testing completed (on m-c, etc.): 1-2 weeks baking time on Nightly.
String changes made by this patch: None.

We want to collect user feedback from more users. The New Tab Page should be enabled for Aurora 12, but will be disabled for Beta in ~4 weeks.
Comment 12 Chris Lee [:clee] 2012-02-09 15:03:34 PST
The approval from drivers is to pref this on for 1 wk starting today and we'll plan to pref this back off by next Thurs, 2/16.  

Can you file a separate bug to pref this back off next week?  Thanks!
Comment 13 Alex Keybl [:akeybl] 2012-02-09 15:56:24 PST
Comment on attachment 593358 [details] [diff] [review]
patch v2

[Triage Comment]
Approving for Aurora 12 with the understanding that this will be pref'd off a week after landing.
Comment 14 Tim Taubert [:ttaubert] 2012-02-09 16:28:06 PST

Filed bug 725873 to pref the New Tab Page off again after a week.
Comment 15 Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2012-03-29 15:31:49 PDT
Verified fixed in Firefox 12.0b3.

Note You need to log in before you can comment on or make changes to this bug.