Closed
Bug 716554
Opened 13 years ago
Closed 13 years ago
MPL 2 upgrade: DOM Inspector
Categories
(mozilla.org :: Licensing, task)
mozilla.org
Licensing
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gerv, Assigned: gerv)
References
Details
Attachments
(1 file, 2 obsolete files)
960.94 KB,
patch
|
crussell
:
review+
|
Details | Diff | Splinter Review |
This bug tracks the MPL 2 upgrade for the project named in the subject line.
The repo is here: http://hg.mozilla.org/dom-inspector/
Gerv
Assignee | ||
Comment 1•13 years ago
|
||
sevenspade: is there any particular time which is good for you?
Gerv
Comment 2•13 years ago
|
||
I can review a patch containing the relicensing changes as soon as you're ready, if that's what comment 1 is referring to.
Assignee | ||
Comment 3•13 years ago
|
||
Here you go :-)
Gerv
Attachment #587751 -
Flags: review?(Sevenspade)
Comment 4•13 years ago
|
||
Comment on attachment 587751 [details] [diff] [review]
Patch v.1
Review of attachment 587751 [details] [diff] [review]:
-----------------------------------------------------------------
::: resources/locale/ca/viewers/boxModel.dtd
@@ +1,3 @@
> +<!-- This Source Code Form is subject to the terms of the Mozilla Public
> +- License, v. 2.0. If a copy of the MPL was not distributed with this
> +- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
The indentation here is messed up for some reason. This occurs in the following files:
/resources/locale/@AB_CD@/viewers/accessibleProps.dtd
/resources/locale/@AB_CD@/viewers/accessibleTree.dtd
/resources/locale/@AB_CD@/viewers/accessibleTreeEvalJSDialog.dtd
/resources/locale/@AB_CD@/viewers/boxModel.dtd
/resources/locale/@AB_CD@/viewers/computedStyle.dtd
/resources/locale/@AB_CD@/viewers/dom.dtd
/resources/locale/@AB_CD@/viewers/domNode.dtd
/resources/locale/@AB_CD@/viewers/jsObject.dtd
/resources/locale/@AB_CD@/viewers/styleRules.dtd
/resources/locale/@AB_CD@/viewers/stylesheets.dtd
/resources/locale/@AB_CD@/viewers/xblBindings.dtd
Where @AB_CD@ is one of {ca, cs, da, de, en-US, fi, fr, ga-IE, hu, nb-NO, pl, pt-BR, ru, sk, sv-SE}. (Note that not all filenames that could be generated from this pattern correspond to files that exist.)
Attachment #587751 -
Flags: review?(Sevenspade) → review-
Assignee | ||
Comment 5•13 years ago
|
||
Thank you; bug found and fixed.
Gerv
Assignee | ||
Comment 6•13 years ago
|
||
Try this :-)
Gerv
Attachment #587751 -
Attachment is obsolete: true
Attachment #590753 -
Flags: review?(Sevenspade)
Comment 7•13 years ago
|
||
Comment on attachment 590753 [details] [diff] [review]
Patch v.2
Review of attachment 590753 [details] [diff] [review]:
-----------------------------------------------------------------
I wonder if you're using an out-of-date repo? Neither the first patch nor this one touches anything in
dom-inspector/resources/locale/en-GB/
The en-GB localization was added a few days before this bug was opened.
I also noticed that even though the first patch did, this one doesn't touch the (non-)license block in
dom-inspector/resources/locale/sv-SE/viewers/accessibleTreeEvalJSDialog.dtd
Attachment #590753 -
Flags: review?(Sevenspade) → review-
Assignee | ||
Comment 8•13 years ago
|
||
Try this; tree definitely updated, and that odd file relicensed by hand.
Gerv
Attachment #590753 -
Attachment is obsolete: true
Attachment #601962 -
Flags: review?(Sevenspade)
Comment 9•13 years ago
|
||
Comment on attachment 601962 [details] [diff] [review]
Patch v.3
Review of attachment 601962 [details] [diff] [review]:
-----------------------------------------------------------------
There are lots of occurrences in this patch where a blank line is inserted after the license block in cases where one already exists, but they're all ones where the existing "blank line" is really a line containing only spaces. Those need to be dealt with anyway, so whenever that happens, we'll take any extra new lines out along with them.
Attachment #601962 -
Flags: review?(Sevenspade) → review+
Assignee | ||
Comment 10•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•