71658 - Attached patches should appear as (text/plain; patch)

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P2)

Comment 1

[Stephan Niemz]

Why?

Comment 2

[Dave Miller [:justdave]]

Because right now they appear as (text/plain) which makes them indistiguishable 
from other text files.  Bugzilla does keep track of whether it's a patch or not 
(it's a separate radio button when you're uploading the attachment), so why not 
display it?

Comment 3

[Stephan Niemz]

True, I didn't notice that. But in createattachment.cgi it says "text/plain,
diffs", we should use the same wording in each place (but I'm not sure which
one is better).

The initial comment is a bit terse :) - that's why I was asking.

Comment 4

[Jesse Ruderman]

How about just showing (patch)?

Comment 5

[Matthew Tuck [:CodeMachine]]

I agree they should be just patch - a patch should never have another MIME type
to my knowledge.

Comment 6

[Dave Miller [:justdave]]

Patches are now distinctly identified on the patch list.  Timeless, if you
concurr, please mark this fixed.

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

->New (old by now?) product Bugzilla 

Comment 8

[Matthew Tuck [:CodeMachine]]

Timeless has nothing to say, and I agree with Dave, so marking fixed.