Note: There are a few cases of duplicates in user autocompletion which are being worked on.

WalkStackMain64 shouldn't skip frames unless it's walking the thread that called NS_StackWalk

RESOLVED FIXED in mozilla12

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: vladan, Assigned: vladan)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
WalkStackMain64 currently skips the top 3 frames of a stack because it assumes that it is walking the stack of the thread that called NS_StackWalk. However, since bug 713278, NS_StackWalk can walk the stack of any arbitrary thread, in which case it should not skip over any frames.
(Assignee)

Comment 1

6 years ago
Created attachment 587032 [details] [diff] [review]
Patch v1
Attachment #587032 - Flags: review?(dbaron)
(Assignee)

Updated

6 years ago
Component: Breakpad Integration → XPCOM
Product: Toolkit → Core
QA Contact: breakpad.integration → xpcom
Comment on attachment 587032 [details] [diff] [review]
Patch v1

>+    int skip = (data->walkCallingThread ? 3 : 0 ) + data->skipFrames;

No space before the ")".

r=dbaron
Attachment #587032 - Flags: review?(dbaron) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/f531dd09e05b
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/f531dd09e05b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.