Closed
Bug 716590
Opened 14 years ago
Closed 14 years ago
WalkStackMain64 shouldn't skip frames unless it's walking the thread that called NS_StackWalk
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: vladan, Assigned: vladan)
References
Details
Attachments
(1 file)
|
2.75 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
WalkStackMain64 currently skips the top 3 frames of a stack because it assumes that it is walking the stack of the thread that called NS_StackWalk. However, since bug 713278, NS_StackWalk can walk the stack of any arbitrary thread, in which case it should not skip over any frames.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #587032 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•14 years ago
|
Component: Breakpad Integration → XPCOM
Product: Toolkit → Core
QA Contact: breakpad.integration → xpcom
Comment on attachment 587032 [details] [diff] [review]
Patch v1
>+ int skip = (data->walkCallingThread ? 3 : 0 ) + data->skipFrames;
No space before the ")".
r=dbaron
Attachment #587032 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Target Milestone: --- → mozilla12
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•