713278 - Teach NS_StackWalk to walk the stack of other threads too on Windows

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(no longer active)]

We need this for the profiler.  Vladan needs this for his chromehang work.  Seems like everybody wants a smarter NS_StackWalk!

Comment 1

[(no longer active)]

Attachment: Patch (v1)

I used uintptr_t, because there seems to be no good way of getting a HANDLE out of a PRThread.

Comment 2

[(no longer active)]

Attachment: Patch (v2)

No default arguments in C!

Comment 3

[Mozilla RelEng Bot]

Try run for a0ded2d34b1a is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a0ded2d34b1a
Results (out of 14 total builds):
    exception: 4
    failure: 10
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a0ded2d34b1a

Comment 4

[Mozilla RelEng Bot]

Try run for 7120721080de is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7120721080de
Results (out of 207 total builds):
    exception: 1
    success: 180
    warnings: 26
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7120721080de

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 584125 [details] [diff] [review]
Patch (v2)

>+    HANDLE targetThread = ::GetCurrentThread();
>+    if (aThread) {
>+        targetThread = reinterpret_cast<HANDLE> (aThread);
>+    }

Why not do an if/else to avoid the GetCurrentThread call?



I suspect you'll have to adjust this code a bit once you try to add a second platform (e.g., uintptr_t as the thread type, 0/null as the indicator for current thread), but I guess you'll hit that when you hit that, and this seems ok for now.

r=dbaron

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b72fc52dfe1

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/1b72fc52dfe1