Closed Bug 716628 Opened 12 years ago Closed 12 years ago

Support "turn" unit from CSS3 Values and Units

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: ayg, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

"""
turn
Turns. There is 1 turn in a full circle.
"""
http://dev.w3.org/csswg/css3-values/#turn

Test case:
data:text/html,<!doctype html>
<style>div {
height:50px;
width:50px;
background:blue;
-moz-transform:rotate(0.125turn);
}</style>
<div></div>

The square should be tilted 45 degrees.  In Firefox 12.0a1 (2012-01-09), it's not.  In IE9, Chrome 17 dev, and Opera Next 12.00 alpha, if the prefix is adjusted, it is.  This causes Firefox to fail some of the 2D Transform tests I'm writing.
Pretty straightforward
Attachment #587242 - Flags: review?(dbaron)
Assignee: nobody → bzbarsky
Priority: -- → P3
Whiteboard: [need review]
Comment on attachment 587242 [details] [diff] [review]
Implement support for 'turn' unit in CSS.

Also adjust the switch in the SetGradient function in nsRuleNode.cpp, and add a test for the gradient angle that fails without that adjustment.

r=dbaron with that
Attachment #587242 - Flags: review?(dbaron) → review+
Gah.  I thought I'd fixed that switch....  I did hit the assert, but of course that doesn't make mochitest fail.

I'll add a test to test_computed_style.html.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a096800c8f6b
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/a096800c8f6b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 726465
Blocks: css-values-3
You need to log in before you can comment on or make changes to this bug.