Closed
Bug 716628
Opened 13 years ago
Closed 13 years ago
Support "turn" unit from CSS3 Values and Units
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: ayg, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
18.18 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
"""
turn
Turns. There is 1 turn in a full circle.
"""
http://dev.w3.org/csswg/css3-values/#turn
Test case:
data:text/html,<!doctype html>
<style>div {
height:50px;
width:50px;
background:blue;
-moz-transform:rotate(0.125turn);
}</style>
<div></div>
The square should be tilted 45 degrees. In Firefox 12.0a1 (2012-01-09), it's not. In IE9, Chrome 17 dev, and Opera Next 12.00 alpha, if the prefix is adjusted, it is. This causes Firefox to fail some of the 2D Transform tests I'm writing.
|
Assignee | |
Comment 1•13 years ago
|
||
Pretty straightforward
Attachment #587242 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → bzbarsky
Priority: -- → P3
Whiteboard: [need review]
Comment on attachment 587242 [details] [diff] [review]
Implement support for 'turn' unit in CSS.
Also adjust the switch in the SetGradient function in nsRuleNode.cpp, and add a test for the gradient angle that fails without that adjustment.
r=dbaron with that
Attachment #587242 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Gah. I thought I'd fixed that switch.... I did hit the assert, but of course that doesn't make mochitest fail.
I'll add a test to test_computed_style.html.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla13
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Keywords: dev-doc-needed
|
||
Comment 6•13 years ago
|
||
Updated
https://developer.mozilla.org/en/CSS/angle
and
https://developer.mozilla.org/en/Firefox_13_for_developers#CSS
Keywords: dev-doc-needed → dev-doc-complete
Blocks: css-values-3
You need to log in
before you can comment on or make changes to this bug.
Description
•