Last Comment Bug 726465 - eCSSUnit_Turn is missing from nsCSSValue::SizeOfExcludingThis
: eCSSUnit_Turn is missing from nsCSSValue::SizeOfExcludingThis
Status: RESOLVED FIXED
: assertion, testcase
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- normal (vote)
: mozilla13
Assigned To: Jesse Ruderman
:
Mentors:
Depends on:
Blocks: randomstyles 716628
  Show dependency treegraph
 
Reported: 2012-02-12 13:06 PST by Jesse Ruderman
Modified: 2012-02-13 09:09 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (load about:memory to abort) (76 bytes, text/html)
2012-02-12 13:06 PST, Jesse Ruderman
no flags Details
stack trace (14.52 KB, text/plain)
2012-02-12 13:07 PST, Jesse Ruderman
no flags Details
patch (619 bytes, patch)
2012-02-12 13:09 PST, Jesse Ruderman
bzbarsky: review+
Details | Diff | Review

Description Jesse Ruderman 2012-02-12 13:06:52 PST
Created attachment 596512 [details]
testcase (load about:memory to abort)

###!!! ABORT: bad nsCSSUnit: 'false', file layout/style/nsCSSValue.cpp, line 1247

History:
* The memory reporter was added in bug 671299 part 3
* The turn unit was added in bug 716628
Comment 1 Jesse Ruderman 2012-02-12 13:07:32 PST
Created attachment 596513 [details]
stack trace
Comment 2 Jesse Ruderman 2012-02-12 13:09:17 PST
Created attachment 596514 [details] [diff] [review]
patch
Comment 3 Jesse Ruderman 2012-02-12 13:16:13 PST
Looks like the fuzzer just used the value from

https://hg.mozilla.org/mozilla-central/file/a096800c8f6b/layout/style/test/property_database.js#l1173

and then loaded about:memory.
Comment 4 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-02-12 16:27:27 PST
Comment on attachment 596514 [details] [diff] [review]
patch

Yeah, looks like this code appeared after I wrote the patch but before I landed it...  and we had no automated tests that would catch this.  :(

r=me
Comment 5 Nicholas Nethercote [:njn] (on vacation until July 11) 2012-02-12 16:44:28 PST
> Yeah, looks like this code appeared after I wrote the patch but before I
> landed it...  and we had no automated tests that would catch this.  :(

Bug 699307 is open for improving testing of memory reporters.  It has an r- patch that runs all the memory reporters on a blank tab, but I guess it would be much better to load some page that does a ton of stuff first.  Any suggestions for such a page?  I assume accessing random internet sites is not good in tests, i.e. the pages should be local?
Comment 7 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-02-12 18:15:51 PST
The test machines black-hole external IPs, as I recal.  So if you check in a test that touches random stuff on the internet, it should always go orange with a test timeout.  So yes, test pages should be local....
Comment 8 Jesse Ruderman 2012-02-12 18:35:20 PST
Could you run all the memory reporters after each mochitest?
Comment 9 Nicholas Nethercote [:njn] (on vacation until July 11) 2012-02-12 18:54:52 PST
(In reply to Jesse Ruderman from comment #8)
> Could you run all the memory reporters after each mochitest?

I don't know how to do that... it sounds expensive -- it'd probably add a second or so to every mochitest.
Comment 10 Marco Bonardo [::mak] 2012-02-13 09:09:19 PST
https://hg.mozilla.org/mozilla-central/rev/46c00abe05a4

Note You need to log in before you can comment on or make changes to this bug.