71670 - POP should re-ask for password if the entered is not correct, w/o throwing up an extra alert.

Status: VERIFIED FIXED

(MailNews Core :: Networking: POP, defect, P2)

Description

[hirata masakazu]

2001030911 trunk for Mac.
Mail/News
POP account is the default.
Type a wrong password when prompted for input.
Result:Mozilla displays that you have to contact the server administrator or try
again later.
Expected result:The other dialog that describes the error and then a new
password dialog should appear.

Comment 1

[Håkan Waara]

Good catch!

I suggest a different password input dialog with the text "The entered password
was not correct. Try again?" and then a textfield and a "OK" and "Cancel" button.

Something like that..

Comment 2

[hirata masakazu]

It used to work that way, and therefore this is a regression.

Comment 3

[scottputterman]

nominating for nsbeta1

Comment 4

[scottputterman]

marking nsbeta1+

Comment 5

[Navin Gupta]

This works for me using windows debug build from yesterday. I am able to
reproduce on Mac. Adding pp keyword.

Comment 6

[Navin Gupta]

Ignore my last comment, I did not understand the problem. Removing pp
keyword. Patch coming up....

Comment 7

[Navin Gupta]

Changing summary to describe the problem correctly...

Comment 8

[Navin Gupta]

Attachment: proposed fix

Comment 9

[Navin Gupta]

cc bienvenu and sspitzer for review

Comment 10

[David :Bienvenu]

you need to add a newline to the end of the properties file. Could you describe
this a little? Is it really a regression in 6.x, or a regression from 4.x?

Comment 11

[Navin Gupta]

Removing regression keyword. This is not a regression. 
It used to behave like this, if user entered wrong password
-->alert describing the error
-->password dialog describing the error  

I changed it to, only
-->password dialog describing the error  

Also I found out that PASSWORD_FAILURE was being used to show failure 
for STAT command, so I added STAT_FAILURE

Comment 12

[David :Bienvenu]

makes sense, r=bienvenu

Comment 13

[David :Bienvenu]

but please fix the .properties file to have a newline at the end before you checkin.

Comment 14

[hirata masakazu]

It seems to have morphed from the original problem.
I like the way it is being fixed, but does it fix the original problem where the
password dialog was not called at all in the following sequence in Mac build?

-->alert describing the error
-->password dialog describing the error  

Comment 15

[Navin Gupta]

Try rebooting your mac and then use the same build 2001-03-09-11. 
You will see the password dialog, again. 

I am very sure because I am using the same build.

david, I will take care of the linefeed in .properties file.

Comment 16

[hirata masakazu]

I do not get it.
I have been suffering with this trouble even in 031608 build.
By rebooting, I can get a password dialog, of course.
However, if you type a wrong one again, there is no more password dialog.

Comment 17

[Navin Gupta]

>>>However, if you type a wrong one again, there is no more password dialog.

I am getting it again. Make sure that you click ok on the alert. Sometimes 
the alert goes behind the app. 

Comment 18

[hirata masakazu]

Now I can see why I am getting this and Navin is not.
I have more than one POP accounts. Only the default account shows the problem I
described.
In 0309 build, there was nothing after the first alert "... you should contact
...". In 031608 build, I get "Unknown Error 804b0001" alert instead of Password
dialog.
In other POP accounts, I can get the second chance to type a password.

Comment 19

[hirata masakazu]

Now I realize there are a few problems that started around 0309 build involving
the default POP account.
Bug 71803 involves default POP only.

Comment 20

[Navin Gupta]

fix checked in.

Comment 21

[Sheela Ravindran]

verified
win98-2001032306
linux-2001032305
mac-2001032310

Comment 22

[Navin Gupta]

*** Bug 62724 has been marked as a duplicate of this bug. ***