716855 - [Page Thumbnails] Screenshots should contain the the top-left corner

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

The crop rectangle for thumbnails is currently determined by a simple panning algorithm that also adds an x+y offset. Remove that offset so that thumbnails always contain the top-left corner.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Simple patch removing the x and y offset when determining the crop rectangle/size.

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 587294 [details] [diff] [review]
patch v1

Review of attachment 587294 [details] [diff] [review]:
-----------------------------------------------------------------

changes look, r=me. is a test needed, or will current tests cover this change?

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Dietrich Ayala (:dietrich) from comment #2)
> changes look, r=me. is a test needed, or will current tests cover this
> change?

We currently have tests that only check single-color pages (so they see no difference). Not sure if we should add a test for this while we're still searching for the ideal thumbnailing algorithm.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/e3e1d313f956

We'll create more specific tests for the thumbnail algorithm once we figured out what seems the right fit for us.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Tim Taubert [:ttaubert] from comment #4)
> We'll create more specific tests for the thumbnail algorithm once we figured
> out what seems the right fit for us.

Filed bug 721329.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/e3e1d313f956