[Page Thumbnails] Screenshots should contain the the top-left corner

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The crop rectangle for thumbnails is currently determined by a simple panning algorithm that also adds an x+y offset. Remove that offset so that thumbnails always contain the top-left corner.
(Assignee)

Comment 1

5 years ago
Created attachment 587294 [details] [diff] [review]
patch v1

Simple patch removing the x and y offset when determining the crop rectangle/size.
(Assignee)

Updated

5 years ago
Attachment #587294 - Flags: review?(dietrich)
Comment on attachment 587294 [details] [diff] [review]
patch v1

Review of attachment 587294 [details] [diff] [review]:
-----------------------------------------------------------------

changes look, r=me. is a test needed, or will current tests cover this change?
Attachment #587294 - Flags: review?(dietrich) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Dietrich Ayala (:dietrich) from comment #2)
> changes look, r=me. is a test needed, or will current tests cover this
> change?

We currently have tests that only check single-color pages (so they see no difference). Not sure if we should add a test for this while we're still searching for the ideal thumbnailing algorithm.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/e3e1d313f956

We'll create more specific tests for the thumbnail algorithm once we figured out what seems the right fit for us.
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
(Assignee)

Comment 5

5 years ago
(In reply to Tim Taubert [:ttaubert] from comment #4)
> We'll create more specific tests for the thumbnail algorithm once we figured
> out what seems the right fit for us.

Filed bug 721329.
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e3e1d313f956
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.