Last Comment Bug 716855 - [Page Thumbnails] Screenshots should contain the the top-left corner
: [Page Thumbnails] Screenshots should contain the the top-left corner
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 12
Assigned To: Tim Taubert [:ttaubert]
:
Mentors:
Depends on:
Blocks: 716538
  Show dependency treegraph
 
Reported: 2012-01-10 05:04 PST by Tim Taubert [:ttaubert]
Modified: 2012-01-26 10:04 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (2.83 KB, patch)
2012-01-10 06:56 PST, Tim Taubert [:ttaubert]
dietrich: review+
Details | Diff | Review

Description Tim Taubert [:ttaubert] 2012-01-10 05:04:20 PST
The crop rectangle for thumbnails is currently determined by a simple panning algorithm that also adds an x+y offset. Remove that offset so that thumbnails always contain the top-left corner.
Comment 1 Tim Taubert [:ttaubert] 2012-01-10 06:56:05 PST
Created attachment 587294 [details] [diff] [review]
patch v1

Simple patch removing the x and y offset when determining the crop rectangle/size.
Comment 2 Dietrich Ayala (:dietrich) 2012-01-25 16:27:19 PST
Comment on attachment 587294 [details] [diff] [review]
patch v1

Review of attachment 587294 [details] [diff] [review]:
-----------------------------------------------------------------

changes look, r=me. is a test needed, or will current tests cover this change?
Comment 3 Tim Taubert [:ttaubert] 2012-01-25 16:33:31 PST
(In reply to Dietrich Ayala (:dietrich) from comment #2)
> changes look, r=me. is a test needed, or will current tests cover this
> change?

We currently have tests that only check single-color pages (so they see no difference). Not sure if we should add a test for this while we're still searching for the ideal thumbnailing algorithm.
Comment 4 Tim Taubert [:ttaubert] 2012-01-26 02:41:27 PST
https://hg.mozilla.org/integration/fx-team/rev/e3e1d313f956

We'll create more specific tests for the thumbnail algorithm once we figured out what seems the right fit for us.
Comment 5 Tim Taubert [:ttaubert] 2012-01-26 03:01:07 PST
(In reply to Tim Taubert [:ttaubert] from comment #4)
> We'll create more specific tests for the thumbnail algorithm once we figured
> out what seems the right fit for us.

Filed bug 721329.
Comment 6 Tim Taubert [:ttaubert] 2012-01-26 10:04:48 PST
https://hg.mozilla.org/mozilla-central/rev/e3e1d313f956

Note You need to log in before you can comment on or make changes to this bug.