The default bug view has changed. See this FAQ.

Source Editor should highlight the current line in HTML documents

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: past, Assigned: msucan)

Tracking

({dev-doc-complete})

Trunk
Firefox 13
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sourceeditor][orion][fixed-in-fx-team])

Attachments

(1 attachment, 2 obsolete attachments)

The script debugger sometimes displays HTML documents for inline scripts. In these cases we need to have SE_setMode do setHighlightCaretLine(true), as it does for JS and CSS files.
(Assignee)

Comment 1

5 years ago
Thanks for the bug report!


(In reply to Panos Astithas [:past] from comment #0)
> The script debugger sometimes displays HTML documents for inline scripts. In
> these cases we need to have SE_setMode do setHighlightCaretLine(true), as it
> does for JS and CSS files.

The highlighter for HTML mode does not have the setHighlightCaretLine(true) method, unfortunately. The approach there is different...
(Assignee)

Updated

5 years ago
Assignee: nobody → mihai.sucan
(Assignee)

Comment 2

5 years ago
Created attachment 592244 [details] [diff] [review]
proposed patch

This changes the way the current line highlight is implemented, as suggested by the Orion team. Now it works with the HTML mode as well.

Please let me know if this is fine with you.
Attachment #592244 - Flags: review?(rcampbell)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Depends on: 707987
(Assignee)

Updated

5 years ago
Blocks: 712982
Comment on attachment 592244 [details] [diff] [review]
proposed patch

looks good.
Attachment #592244 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 593577 [details] [diff] [review]
some fixes

Found a minor bug while working on the rest of the patches in my queue. Fixed.

Thanks for the r+!
Attachment #592244 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
Created attachment 595782 [details] [diff] [review]
[in-fx-team] rebased patch
Attachment #593577 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
We need to document the new highlightCurrentLine option. Thanks!
Keywords: dev-doc-needed
(Assignee)

Comment 7

5 years ago
Comment on attachment 595782 [details] [diff] [review]
[in-fx-team] rebased patch

Landed:
https://hg.mozilla.org/integration/fx-team/rev/0815f202f7f1
Attachment #595782 - Attachment description: rebased patch → [in-fx-team] rebased patch
(Assignee)

Updated

5 years ago
Whiteboard: [sourceeditor][orion] → [sourceeditor][orion][fixed-in-fx-team]
(Assignee)

Comment 8

5 years ago
Comment on attachment 595782 [details] [diff] [review]
[in-fx-team] rebased patch

backedout due to test failure:
https://hg.mozilla.org/integration/fx-team/rev/b18c023badad
Attachment #595782 - Attachment description: [in-fx-team] rebased patch → rebased patch
(Assignee)

Updated

5 years ago
Whiteboard: [sourceeditor][orion][fixed-in-fx-team] → [sourceeditor][orion][backedout]
(Assignee)

Comment 9

5 years ago
Comment on attachment 595782 [details] [diff] [review]
[in-fx-team] rebased patch

Landed:
https://hg.mozilla.org/integration/fx-team/rev/aa44ffe9db74
Attachment #595782 - Attachment description: rebased patch → [in-fx-team] rebased patch
(Assignee)

Updated

5 years ago
Whiteboard: [sourceeditor][orion][backedout] → [sourceeditor][orion][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/aa44ffe9db74
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Already documented, tweaked to mention that it's new in Firefox 13.

https://developer.mozilla.org/en/JavaScript_code_modules/source-editor.jsm#Configuration_defaults_constants
https://developer.mozilla.org/en/JavaScript_code_modules/source-editor.jsm#The_editor_configuration_object

Added to Firefox 13 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.