Permanent orange: TEST-UNEXPECTED-FAIL | test-about-support.js | test-about-support.js::*

RESOLVED FIXED in Thunderbird 12.0

Status

Thunderbird
Testing Infrastructure
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: aceman)

Tracking

12 Branch
Thunderbird 12.0

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed by bug 631909])

Attachments

(1 obsolete attachment)

The patch for bug 631909 changed the string key "aboutSupport.modifiedPrefsTitle" on us, and broke our about:support.
Blocks: 631909
Assignee: nobody → mconley
Created attachment 587811 [details] [diff] [review]
Patch v1

Tests are now passing locally.
Comment on attachment 587811 [details] [diff] [review]
Patch v1

This fixes it.
Attachment #587811 - Flags: review?(mbanner)
(Assignee)

Comment 3

5 years ago
No wonder. I specified in bug 631909 that both patches (for FF and TB) must be merged simultaneously. Dao only took the FF patch.
Can you merge the other one? This bug should vanish.
(Assignee)

Comment 4

5 years ago
I even have review there, no need to bother mbanner.
Ah, k - I'll check in the patch in bug 631909.
Comment on attachment 587811 [details] [diff] [review]
Patch v1

There's a patch in bug 631909 that fixes this - it just didn't get checked in to comm-central.
Attachment #587811 - Attachment is obsolete: true
Attachment #587811 - Flags: review?(mbanner)
The patch in bug 631909 (https://bugzilla.mozilla.org/attachment.cgi?id=583580) was committed to comm-central as http://hg.mozilla.org/comm-central/rev/c01205ffb4f8
Assignee: mconley → acelists
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
(Assignee)

Comment 8

5 years ago
Can you tell me how to avoid this next time?
I have several more bugs where there are patches for FF and TB that must be merged at once. But they must be done as two files due to 'hg mq' and possibly checkin rights of various people.
Hardware: x86_64 → All
Whiteboard: [fixed by bug 631909]
aceman:

For things like this, I think it's enough to make sure that there's a TB developer CC'd on the bug.  Pinging us in IRC also helps. :)

-Mike
You need to log in before you can comment on or make changes to this bug.