717402 - Permanent orange: TEST-UNEXPECTED-FAIL | test-about-support.js | test-about-support.js::*

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

The patch for bug 631909 changed the string key "aboutSupport.modifiedPrefsTitle" on us, and broke our about:support.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Tests are now passing locally.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 587811 [details] [diff] [review]
Patch v1

This fixes it.

Comment 3

[:aceman]

No wonder. I specified in bug 631909 that both patches (for FF and TB) must be merged simultaneously. Dao only took the FF patch.
Can you merge the other one? This bug should vanish.

Comment 4

[:aceman]

I even have review there, no need to bother mbanner.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Ah, k - I'll check in the patch in bug 631909.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 587811 [details] [diff] [review]
Patch v1

There's a patch in bug 631909 that fixes this - it just didn't get checked in to comm-central.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

The patch in bug 631909 (https://bugzilla.mozilla.org/attachment.cgi?id=583580) was committed to comm-central as http://hg.mozilla.org/comm-central/rev/c01205ffb4f8

Comment 8

[:aceman]

Can you tell me how to avoid this next time?
I have several more bugs where there are patches for FF and TB that must be merged at once. But they must be done as two files due to 'hg mq' and possibly checkin rights of various people.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

aceman:

For things like this, I think it's enough to make sure that there's a TB developer CC'd on the bug.  Pinging us in IRC also helps. :)

-Mike