717442 - WebGL should shadow GL state so as to minimize state queries

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

In most cases, GL state access should be trivial, but it's not guaranteed to be so, and will probably not be trivial on some drivers.

As such, we should shadow what state we commonly use so as to minimize extra queries.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

We already do shadow some state, for the reason you mention.

What more do you think we should shadow?

Comment 2

[Kelsey Gilbert [:jgilbert]]

I think the only pressing need is framebuffer bindings. I was trying to think if there would be a nice way to make shadowing more general.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Shadow bound FBO ids.

This seems to work.

I'm not sure why my previous attempt didn't work.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Shadow bound FBO ids.

Fixed a warning.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 595267 [details] [diff] [review]
Shadow bound FBO ids.

Review of attachment 595267 [details] [diff] [review]:
-----------------------------------------------------------------

r=me provided the following is addressed:

::: gfx/gl/GLContext.h
@@ +856,5 @@
> +
> +
> +
> +    GLuint mBoundDrawFBO;
> +    GLuint mBoundReadFBO;

That should probably not be public.

Comment 6

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c49ea176da2

Comment 7

[Kelsey Gilbert [:jgilbert]]

Attachment: Shadow bound FBO ids.

Final patch, carrying r+ forward, and fixing the bug number on the patch. (Patch was pointing at bug 717422)

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2c49ea176da2