717451 - Telephony: Keep telephony objects on multiple pages in sync

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

We limit the use to a single content uri but theoretically it could be open in more than one window. Also chrome can poke its nose in any time it wants, so we need a mechanism to keep things in sync. Hopefully this is simple enough and we can expand further if we need to in the future.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Note the dialer app will live in a separate process in the near future.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

We're going to do something different here.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Nevermind, going to do this after all.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v2

Moar better.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v2.1

This adds the query/ref string stripping to the permissions check.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 599970 [details] [diff] [review]
Patch, v2.1

Review of attachment 599970 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with those changes.

::: dom/telephony/Telephony.cpp
@@ +134,5 @@
>    if (mActiveCall) {
>      // Put the call on hold?
>      NS_NOTYETIMPLEMENTED("Implement me!");
>    }
>    mActiveCall = aCall;

Remove this

@@ +140,5 @@
> +  // Update all the other Telephony objects to keep them in sync.
> +  if (aNotifyOthers && gTelephonyList->Length() > 1) {
> +    for (PRUint32 index = 0; index < gTelephonyList->Length(); index++) {
> +      Telephony*& telephony = gTelephonyList->ElementAt(index);
> +      if (telephony != this) {

And this != this check

@@ +154,5 @@
> +{
> +  for (PRUint32 index = 0; index < mCalls.Length(); index++) {
> +    nsRefPtr<TelephonyCall>& call = mCalls[index];
> +    if (call->CallIndex() == aCallIndex) {
> +      SwitchActiveCall(call, aNotifyOthers);

And have the code here just set mActiveCall = call rather than doing the recursive call.

@@ +543,5 @@
> +              (url = do_QueryInterface(uri)) &&
> +              NS_SUCCEEDED(url->GetPrePath(prePath)) &&
> +              NS_SUCCEEDED(url->GetFilePath(filePath))) {
> +            if (documentURL.Equals(prePath + filePath,
> +                                   nsCaseInsensitiveCStringComparator())) {

Remove the case insensitive part.

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b818dc32f61

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/5b818dc32f61