Use a whitelist for mozTelephony instead of a single url

RESOLVED FIXED in mozilla12

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vingtetun, Assigned: vingtetun)

Tracking

Trunk
mozilla12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 591260 [details] [diff] [review]
Use a whitelist

This will let Gaia's homescreen use navigator.mozTelephony.addEventListener to react to incoming calls.
Attachment #591260 - Flags: review?(bent.mozilla)
Comment on attachment 591260 [details] [diff] [review]
Use a whitelist

Review of attachment 591260 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #591260 - Flags: review?(bent.mozilla) → review+
OS: Linux → All
Hardware: x86_64 → All
Note for posterity: this is a placeholder for two things, real permissions support, and an intents impl in gecko/b2g.
Blocks: 674726
Comment on attachment 591260 [details] [diff] [review]
Use a whitelist

This patch is not enough by itself. Currently the navigator.mozTelephony implementation does not deal with being exposed to multiple pages currently. Bug 720892 is an example of erroneous behaviour (we might morph that bug into fixing this since bent also expressed the desire to loosen the restrictions on mozTelephony access.)

Until that happens, though, I don't think we should land this patch.
Attachment #591260 - Flags: feedback-
Philipp, open a bug and make it block this one but f- means the patch is wrong which is not the case here. If there is a bug blocking this one, it's clearer that this one has to be hold until the blocker is fixed.
Depends on: 720892
> Until that happens, though, I don't think we should land this patch.

Agreed. That's the reason I've not landed it yesterday.
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #4)
> Philipp, open a bug and make it block this one but f- means the patch is
> wrong which is not the case here. If there is a bug blocking this one, it's
> clearer that this one has to be hold until the blocker is fixed.

Fair enough. I morphed bug 720892.
Comment on attachment 591260 [details] [diff] [review]
Use a whitelist

FWIW, I don't disagree with the patch itself. So you're right about the bugzilla mechanics, Mounir.
Attachment #591260 - Flags: feedback- → feedback+
This was assimilated into the patch in bug 717451.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Depends on: 717451
No longer depends on: 720892
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.