717522 - Android single locale fixes

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Aki Sasaki (not active)]

1. Android-xul is still failing, on res/values/strings.xml :

make[2]: Entering directory `/builds/slave/m-cen-andrd-xul-l10n-1/mozilla-central/obj-l10n/embedding/android'
make[2]: Leaving directory `/builds/slave/m-cen-andrd-xul-l10n-1/mozilla-central/obj-l10n/embedding/android'
make[2]: *** No rule to make target `res/values/strings.xml', needed by `gecko.ap_'.  Stop.
make[1]: *** [repackage-zip] Error 2
make[1]: Leaving directory `/builds/slave/m-cen-andrd-xul-l10n-1/mozilla-central/obj-l10n/mobile/xul/locales'
make: *** [repackage-zip-es-ES] Error 2
command: END (2.03s elapsed)

2. We're not uploading the xpi.  This may be an issue once we stop building mobile desktop (possibly also Firefox 11 timeframe), since we will have zero mobile xpis generated then.

I'm not blocking bug 698425 on this since we can land that without having these two things, but I'm filing for followup.

Comment 1

[Axel Hecht [:Pike]]

I suspect this is another aspect of bug 714553, let's see if we get a fix for those.

Comment 2

[Aki Sasaki (not active)]

Aha, yeah.
Does that cover the missing xpi, though?

Comment 3

[Axel Hecht [:Pike]]

So, for android native, we're not doing language packs by definition, because android doesn't support that. For the XUL UI, the android native bits still don't, though the impact is smaller. Not really a big deal for us, though.

And yes, the original xul plan to ship our localizations as language packs was flawed in the details :-(

Comment 4

[Alex Keybl [:akeybl]]

Is this really a fennecnative-betablocker or even a concern for XUL 11? It seems like we should just continue to ship multi-locale APKs for XUL.

Comment 5

[Axel Hecht [:Pike]]

Aki, bug 714553 has a hacky fix landed on central, do we still have a problem here? Can you re-test?

Comment 6

[Aki Sasaki (not active)]

They're repacking nightly, and all burning.

http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android-xul-l10n/ is nonexistent, as is http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-aurora-android-xul-l10n/

I will upload some logs.

Comment 7

[Aki Sasaki (not active)]

Attachment: l10n logs for m-c and m-a android-xul (zipfile)

Comment 8

[Axel Hecht [:Pike]]

Attachment: port strings.xml/chrome dependency hack to gecko.ap_

OK, I think I see what's going on.

Aki, this is the same hack for we have for the regular builds, making the target not rely on libs:: creating strings.xml, but depending on the chrome target, which then dives into locales to create that.

Comment 9

[Aki Sasaki (not active)]

Comment on attachment 592403 [details] [diff] [review]
port strings.xml/chrome dependency hack to gecko.ap_

This looks good to me.
If you want to land this, I'm ok with that.
If you want me to test this in staging first, I can do that on Monday.

Comment 10

[Axel Hecht [:Pike]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0ae127e29cd, just landed it.

Comment 11

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/c0ae127e29cd

Comment 12

[Matt Brubeck (:mbrubeck)]

Sorry, I backed this out because of bug 722808:
https://hg.mozilla.org/mozilla-central/rev/1410782d557d

The patch is still in Firefox 12 (Aurora); I'll request approval to back it out there too.

Comment 13

[Aki Sasaki (not active)]

We have no plans to release android-xul single locale repacks.
-> WONTFIX or INVALID ?