Closed Bug 717522 Opened 8 years ago Closed 8 years ago

Android single locale fixes

Categories

(Firefox for Android :: General, defect, P1)

ARM
Android
defect

Tracking

()

RESOLVED WONTFIX
Firefox 12
Tracking Status
firefox11 --- wontfix
firefox12 --- wontfix
firefox13 --- wontfix
fennec 11+ ---

People

(Reporter: aki, Assigned: Pike)

References

Details

Attachments

(2 files)

1. Android-xul is still failing, on res/values/strings.xml :

make[2]: Entering directory `/builds/slave/m-cen-andrd-xul-l10n-1/mozilla-central/obj-l10n/embedding/android'
make[2]: Leaving directory `/builds/slave/m-cen-andrd-xul-l10n-1/mozilla-central/obj-l10n/embedding/android'
make[2]: *** No rule to make target `res/values/strings.xml', needed by `gecko.ap_'.  Stop.
make[1]: *** [repackage-zip] Error 2
make[1]: Leaving directory `/builds/slave/m-cen-andrd-xul-l10n-1/mozilla-central/obj-l10n/mobile/xul/locales'
make: *** [repackage-zip-es-ES] Error 2
command: END (2.03s elapsed)

2. We're not uploading the xpi.  This may be an issue once we stop building mobile desktop (possibly also Firefox 11 timeframe), since we will have zero mobile xpis generated then.

I'm not blocking bug 698425 on this since we can land that without having these two things, but I'm filing for followup.
I suspect this is another aspect of bug 714553, let's see if we get a fix for those.
Depends on: 714553
Aha, yeah.
Does that cover the missing xpi, though?
So, for android native, we're not doing language packs by definition, because android doesn't support that. For the XUL UI, the android native bits still don't, though the impact is smaller. Not really a big deal for us, though.

And yes, the original xul plan to ship our localizations as language packs was flawed in the details :-(
tracking-fennec: --- → 11+
Priority: -- → P1
Is this really a fennecnative-betablocker or even a concern for XUL 11? It seems like we should just continue to ship multi-locale APKs for XUL.
Aki, bug 714553 has a hacky fix landed on central, do we still have a problem here? Can you re-test?
OK, I think I see what's going on.

Aki, this is the same hack for we have for the regular builds, making the target not rely on libs:: creating strings.xml, but depending on the chrome target, which then dives into locales to create that.
Assignee: nobody → l10n
Attachment #592403 - Flags: review?(aki)
Comment on attachment 592403 [details] [diff] [review]
port strings.xml/chrome dependency hack to gecko.ap_

This looks good to me.
If you want to land this, I'm ok with that.
If you want me to test this in staging first, I can do that on Monday.
Attachment #592403 - Flags: review?(aki) → review+
https://hg.mozilla.org/mozilla-central/rev/c0ae127e29cd
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Sorry, I backed this out because of bug 722808:
https://hg.mozilla.org/mozilla-central/rev/1410782d557d

The patch is still in Firefox 12 (Aurora); I'll request approval to back it out there too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
We have no plans to release android-xul single locale repacks.
-> WONTFIX or INVALID ?
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → WONTFIX
Depends on: 722808
You need to log in before you can comment on or make changes to this bug.