The default bug view has changed. See this FAQ.

XUL Fennec nightly build fails with "L10NBASEDIR not defined by configure" in embedding/android/locales

RESOLVED FIXED in Firefox 13

Status

Fennec Graveyard
General
--
major
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

({regression})

Firefox 12
Firefox 13
ARM
Android
regression

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Last night's XUL Nightly build failed twice in a row with this error:

https://tbpl.mozilla.org/php/getParsedLog.php?id=8974969&tree=Firefox
Android XUL mozilla-central nightly on 2012-01-31 05:54:53 PST for push 3f26b7bee352

06:45:59     INFO -  make[5]: Entering directory `/builds/slave/m-cen-andrd-xul-ntly/build/obj-firefox/embedding/android/locales'
06:45:59    ERROR -  Makefile:66: *** L10NBASEDIR not defined by configure.  Stop.
06:45:59     INFO -  make[5]: Leaving directory `/builds/slave/m-cen-andrd-xul-ntly/build/obj-firefox/embedding/android/locales'
06:45:59    ERROR -  make[4]: *** [chrome] Error 2
06:45:59     INFO -  make[4]: Leaving directory `/builds/slave/m-cen-andrd-xul-ntly/build/obj-firefox/embedding/android/locales'
06:45:59    ERROR -  make[3]: *** [chrome] Error 2
06:45:59     INFO -  make[3]: Leaving directory `/builds/slave/m-cen-andrd-xul-ntly/build/obj-firefox/embedding/android'
06:45:59    ERROR -  make[2]: *** [make-package] Error 2
06:45:59     INFO -  make[2]: Leaving directory `/builds/slave/m-cen-andrd-xul-ntly/build/obj-firefox/mobile/xul/installer'
06:45:59    ERROR -  make[1]: *** [default] Error 2
06:45:59     INFO -  make[1]: Leaving directory `/builds/slave/m-cen-andrd-xul-ntly/build/obj-firefox/mobile/xul/installer'
06:45:59     INFO -  make: *** [package] Error 2
06:45:59    ERROR - Return code: 2
06:45:59    FATAL - Halting on failure while running make package AB_CD=multi
06:45:59    FATAL - Exiting 2
program finished with exit code 2
elapsedTime=409.181453
======== Finished 'python mozharness/scripts/multil10n.py ...' failed (results: 2, elapsed: 6 mins, 49 secs) ========
(Assignee)

Updated

5 years ago
tracking-fennec: --- → ?
status-firefox12: --- → affected

Comment 1

5 years ago
Hrm, Aki?

Comment 2

5 years ago
I'm wondering if this is more l10n fallout from bug 719697.
This looks like specifying L10NBASEDIR in |make package| is now a requirement.

Comment 3

5 years ago
http://hg.mozilla.org/mozilla-central/rev/c0ae127e29cd needs backing out.
This will re-break Android xul single locale (which is also broken by bug 719697) but should hopefully fix Android xul multilocale nightlies.
(Assignee)

Comment 4

5 years ago
Backed out c0ae127e29cd: https://hg.mozilla.org/mozilla-central/rev/1410782d557d

I'll request Aurora approval after nightly builds succeed on mozilla-central.
Assignee: nobody → mbrubeck
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-firefox13: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13

Comment 5

5 years ago
If this merges into mozilla-beta, this may break the 11.0b1 android-xul multilocale release build.
(Assignee)

Comment 6

5 years ago
Created attachment 593533 [details] [diff] [review]
back out bug 717522 on Aurora

[Approval Request Comment]
Regression caused by (bug #): bug 717522

User impact if declined: XUL nightly fails to build

Testing completed (on m-c, etc.): Landed on m-c 1/31.

Risk to taking this patch (and alternatives if risky): Low-risk: this is a backout of a one-line build system change that affects only XUL fennec.

String changes made by this patch: None.
Attachment #593533 - Flags: approval-mozilla-aurora?

Comment 7

5 years ago
Comment on attachment 593533 [details] [diff] [review]
back out bug 717522 on Aurora

[Triage Comment]
Fixes build failure - approved for Aurora 12.
Attachment #593533 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/72dd0b3694fc
status-firefox12: affected → fixed
Comment on attachment 593533 [details] [diff] [review]
back out bug 717522 on Aurora

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

(In reply to Matt Brubeck (:mbrubeck) from comment #8)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/72dd0b3694fc

afaict, this backout landed after the migration from aurora to beta. Therefore we need to backout on beta also, in order to avoid android-xul bustage in 11.0betas.
Attachment #593533 - Flags: approval-mozilla-beta?
(Assignee)

Updated

5 years ago
status-firefox11: --- → unaffected
(Assignee)

Comment 10

5 years ago
Comment on attachment 593533 [details] [diff] [review]
back out bug 717522 on Aurora

Firefox 11 (beta) is not affected by this bug, because the patch which this backs never landed in Firefox 11 and is not in mozilla-beta:

https://hg.mozilla.org/releases/mozilla-beta/file/default/embedding/android/Makefile.in#l189
Attachment #593533 - Flags: approval-mozilla-beta?
(Assignee)

Updated

5 years ago
Blocks: 717522
Keywords: regression
(In reply to John O'Duinn [:joduinn] from comment #9)
> (In reply to Matt Brubeck (:mbrubeck) from comment #8)
> > https://hg.mozilla.org/releases/mozilla-aurora/rev/72dd0b3694fc
> 
> afaict, this backout landed after the migration from aurora to beta.
> Therefore we need to backout on beta also, in order to avoid android-xul
> bustage in 11.0betas.

(In reply to Matt Brubeck (:mbrubeck) from comment #10)
> Comment on attachment 593533 [details] [diff] [review]
> back out bug 717522 on Aurora
> 
> Firefox 11 (beta) is not affected by this bug, because the patch which this
> backs never landed in Firefox 11 and is not in mozilla-beta:
> 
> https://hg.mozilla.org/releases/mozilla-beta/file/default/embedding/android/
> Makefile.in#l189

ok, thanks :mbrubeck.
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.