717787 - Suggestions from <datalist> are not shown in Native Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Martijn Wargers (dead)]

Basically a revisit from bug 628616.
See also testcase from there: https://bugzilla.mozilla.org/attachment.cgi?id=506705

From bug 628616, comment 0:
"
With <datalist> and the list attribute on the input element, authors can provide suggestions to the user. On Firefox Desktop, they are shown like autocomplete suggestions. It would be nice to have them shown in Firefox Mobile given that authors should check if list and datalist are available and might assume that it will work on Firefox Mobile.
"

Comment 1

[Markus Popp]

Should this bug also get the "fennecnative-releaseblocker" status to retain parity with XUL?

Comment 2

[:Margaret Leibovic]

Attachment: patch

This basically just copies what we did in XUL fennec. As a follow-up we may want to look into a way to draw a divider between form autocomplete suggestions and datalist suggestions the way desktop does.

This patch is built on top of my patches from bug 704879. If you want to test, you can apply my patch queue here: http://hg.mozilla.org/users/margaret.leibovic_gmail.com/patches/.

I made a page to test the autocomplete/datalist interaction: http://people.mozilla.com/~mleibovic/test/datalist.html. I tried to figure out a way to make an automated test for this, but it still seems impossible to test features that touch both our Java UI and content. What I really want is a way to integrate some privileged JS into the robocop test framework - if we had that we could steal some code from the browser-chrome test harness to simulate click/keypress events.

Comment 3

[:Margaret Leibovic]

Attachment: patch

Oops, wrong file.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

we can either have our test pages act as the source of the js stuff, or we have roboextender to poke from java->chrome.  I am sure we can work something out.

Comment 5

[:Margaret Leibovic]

Attachment: patch (un-bitrotted)

This applies on inbound now. Switching review to mbrubeck, since mfinkle is on PTO.

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6250fad749e2

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/6250fad749e2

Comment 8

[Cristian Nicolae (:xti)]

Suggestions are displayed right after a tap is done in the <datalist> field. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-21)
Device: Galaxy Nexus
OS: Android 4.0.2