717796 - expand/close marks alignment wrong (follow-up)

Status: RESOLVED WORKSFORME

(DevTools :: Style Editor, defect, P3)

Description

[Stefan]

Attachment: expandclose.png

User Agent:  

Steps to reproduce:

1. Open a page
2. Open the Style Inspector.
3. Select HTML View


Actual results:

3. Expand/Close marks seem not to be aligned to the baseline (expandclose.png)


Expected results:

3. Expand/Close marks appear as if they are aligned to the baseline. (expandclose1.png)

Issue is caused by http://hg.mozilla.org/mozilla-central/rev/cd03664850ed (Bug 709756)

Comment 1

[Stefan]

Attachment: expandclose1.png

Comment 2

[Leonard Camacho [:lcamacho]]

Stefan, which is your distribution and theme?

Comment 3

[Stefan]

openSUSE 11.1 Evergreen. Which theme do you mean?

Comment 4

[Leonard Camacho [:lcamacho]]

Stefan, can you check this again with nightly?

Comment 5

[Stefan]

Attachment: Screenshot of mozilla-central 48c4938eaf57 build

Comment 6

[Paul Rouget [:paul]]

(In reply to Stefan from comment #5)
> Created attachment 671086 [details]
> Screenshot of mozilla-central 48c4938eaf57 build

This is not firefox nightly (it's beta afaict)

Comment 7

[Stefan]

(In reply to Paul Rouget [:paul] from comment #6)
> This is not firefox nightly (it's beta afaict)

I have compiled the current m-c source tree. The nightlies beginning with 2012-09-21 do not run here (Bug 799886). The latest working nightly (2012-09-20) produces the same misalignment.

Comment 8

[Paul Rouget [:paul]]

(In reply to Stefan from comment #7)
> (In reply to Paul Rouget [:paul] from comment #6)
> > This is not firefox nightly (it's beta afaict)
> 
> I have compiled the current m-c source tree.

You're saying that attachment 48 [details] [diff] [review]c4938eaf57 is from current m-c? Please take a screenshot with the about  dialog open. I'm pretty sure your screenshot is from a Firefox 17 instance.

Comment 9

[Stefan]

I'm saying that the attachement "Screenshot of mozilla-central 48c4938eaf57 build" is a screenshot of a running binary which I have compiled from the mozilla-central source tree in the state 48c4938eaf57.

Comment 10

[Stefan]

Attachment: Screenshot of the "About Firefox" dialog

Comment 11

[Paul Rouget [:paul]]

(In reply to Stefan from comment #9)
> I'm saying that the attachement "Screenshot of mozilla-central 48c4938eaf57
> build" is a screenshot of a running binary which I have compiled from the
> mozilla-central source tree in the state 48c4938eaf57.

So I don't understand why you re-opened the bug then.
This is fixed in nightly.

Comment 12

[Stefan]

I reopened the bug because the issue of misalignment is still present in the mozilla-central repository 48c4938eaf57. 48c4938eaf57 is more recent than the
latest nightly available (which is 2012-10-13-03-05-42-mozilla-central).

Comment 13

[Stefan]

BTW: Shall I report the low contrast issue separately?

Comment 14

[Paul Rouget [:paul]]

48c4938eaf57 refers to a code that is 2 weeks old. During these 2 weeks, we fixed this issue.
Again, this bug is fixed. Don't reopen it.

Comment 15

[Stefan]

Attachment: Screenshot of mozilla-central 847807ab2646 build

Comment 16

[Stefan]

(In reply to Paul Rouget [:paul] from comment #14)
> 48c4938eaf57 refers to a code that is 2 weeks old.

Yes, Sorry, my fault. hg id now says:
847807ab2646 tip

The arrows are still not OK in 19.0a1.

Comment 17

[Paul Rouget [:paul]]

Hmm, bug 795176 should have fixed that.

Comment 18

[Paul Rouget [:paul]]

Mihai, could you take a quick look at this (at least confirm)? We have fixed the alignment in bug 795176, but apparently, it's off again (might be because of bug 789364).

(sorry, still waiting for my new computer to run Linux)

Comment 19

[Paul Rouget [:paul]]

My guess here is that we use the GTK icon, and depending on the GTK theme, we get alignments problems.

Comment 20

[Mihai Sucan [:msucan]]

Paul: it looks as expected, for me.

Screenshot:
http://img.i7m.de/show/7uljy.png

Changeset: 110235:e87dd11b6c3e (latest from fx-team)
System: Ubuntu 12.04 (ambiance/bright ubuntu theme with large font size)

This looks as it looked in bug 795176. Before that, the icons were slightly off.

I expect it depends on the GTK theme being used.