71790 - Duplicate resolution field should include bug number of original

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement, P1)

Description

[Dave Miller [:justdave]]

I'm thinking something like this in bug_form.pl:

    Status: RESOLVED
Resolution: DUPLICATE (53623)

Where the number in parens is the number of the original bug, clickable, of 
course.  I thought of this trying to come up with some way to display the 
duplicate data from the database in the bug.  That data is now saved in the 
database, but is not displayed anywhere.  We currently have to trust that the 
comments are correct to find the original of a duplicate.

Comment 1

[Matthew Tuck [:CodeMachine]]

I'm thinking for BZ3 we might want to associate a field with each status.  For
example, INVALID might have an invalidation reason, or some such.

This would work the same.

Comment 2

[Matthew Tuck [:CodeMachine]]

Apparently we already have this data, so 2.16.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

->New (old by now?) product Bugzilla 

Comment 4

[Dave Miller [:justdave]]

correcting component

Comment 5

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 6

[Dave Miller [:justdave]]

*** Bug 114318 has been marked as a duplicate of this bug. ***

Comment 7

[Dave Miller [:justdave]]

*** Bug 120513 has been marked as a duplicate of this bug. ***

Comment 8

[Dave Miller [:justdave]]

*** Bug 123737 has been marked as a duplicate of this bug. ***

Comment 9

[Dave Miller [:justdave]]

bumping priority based on the number of dupes.

Comment 10

[Tobias Burnus]

Attachment: First round

Comment 11

[Tobias Burnus]

Take bug (note: I'm away the next two weeks).

Comment 12

[Tobias Burnus]

Attachment: v1.2 - a "==" is not a "eq"

Comment 13

[Bradley Baetz (:bbaetz)]

Comment on attachment 116646 [details] [diff] [review]
v1.2 - a "==" is not a "eq" 

I'd much rather you did this (on demand) in Bug.pm. Also, don't use SendSQL -
use the DBI methods instead.

Comment 14

[Tobias Burnus]

Attachment: v2: Now uses $dbh in Bug.pm

Comment 15

[Tobias Burnus]

Attachment: v2.0.1 Uses $dbh with placeholder (cf. suggestions at developer@)

Comment 16

[Bradley Baetz (:bbaetz)]

Comment on attachment 119286 [details] [diff] [review]
v2.0.1 Uses $dbh with placeholder (cf. suggestions at developer@)

>Index: Bug.pm
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/Bug.pm,v
>retrieving revision 1.30
>diff -u -r1.30 Bug.pm
>--- Bug.pm	23 Feb 2003 07:31:07 -0000	1.30
>+++ Bug.pm	3 Apr 2003 12:22:34 -0000
>@@ -262,6 +262,22 @@
>   return $self;
> }
> 
>+sub duplicate_bug_id {
>+    my ($self) = @_;
>+
>+    return $self->{'duplicate_bug_id'} if exists $self->{'duplicate_bug_id'};
>+
>+    if ($self->{'resolution'} eq 'DUPLICATE') { 
>+        my $dbh = Bugzilla->dbh;
>+        return $self->{'duplicate_bug_id'} =
>+          $dbh->selectrow_array(q{SELECT dupe_of 
>+                                  FROM duplicates
>+                                  WHERE dupe = ?},
>+                                undef,
>+                                $self->{'bug_id'});
>+    }
>+}

If it isn't a duplicate, what should you return? (And should you cache that
result?) Or should you just die?

What happen when process_bug reopens a bug, and then the next bug shows is the
same bug, and the result ends up cached? (I don't know if this matters in our
current process_bug handling, mind you)

>Index: show_bug.cgi

> $vars->{'displayfields'} = \%displayfields;
>+$vars->{'GetBugLink'} = \&GetBugLink;

You don't need this....

>Index: template/en/default/bug/edit.html.tmpl

>+      <td>
>+        [% bug.resolution FILTER html %]
>+        [% IF bug.resolution == "DUPLICATE" %]
>+          [% bug_id = bug.duplicate_bug_id %]
>+          of [% GetBugLink(bug_id,"Bug $bug_id") %]

... because this becomes

[% "Bug $bug_id" FILTER bug_link($bug_id) %]

bug_link is a dynamic filter - it will filter the input text with a link to the
argument bug id.

I suppose it should take a bug object one day, not just the id, and when it
does, duplicate_bug_id can reutrn a bug object. Doesn't matter for now, though.

Comment 17

[Tobias Burnus]

Attachment: v2.0.2 Use FILTER bug_link("Bug $bug_id") instead

> What happen when process_bug reopens a bug, and then the next bug shows is
the
> same bug, and the result ends up cached? (I don't know if this matters in our

> current process_bug handling, mind you)
I haven't check this, but I copied the code from the other items
(groups, actual_time, longdescs, user, choices).

I also return now a undef.

Comment 18

[Gervase Markham [:gerv]]

Comment on attachment 119289 [details] [diff] [review]
v2.0.2 Use FILTER bug_link("Bug $bug_id") instead

>+sub duplicate_bug_id {
>+    my ($self) = @_;
>+
>+    return $self->{'duplicate_bug_id'} if exists $self->{'duplicate_bug_id'};
>+
>+    if ($self->{'resolution'} eq 'DUPLICATE') { 
>+        my $dbh = Bugzilla->dbh;
>+        return $self->{'duplicate_bug_id'} =
>+          $dbh->selectrow_array(q{SELECT dupe_of 
>+                                  FROM duplicates
>+                                  WHERE dupe = ?},
>+                                undef,
>+                                $self->{'bug_id'});
>+    }
>+    return undef;
>+}

That embedded return() is really obscure; it looks like this function just
returns undef. Consider using a local variable, initialised to undef anf set
inside the if test, for clarity.

You can also probably call it dup_id instead of duplicate_bug_id :-)

>-      <td>[% bug.resolution FILTER html %]</td>      
>+      <td>
>+        [% bug.resolution FILTER html %]
>+        [% IF bug.resolution == "DUPLICATE" %]
>+          [% bug_id = bug.duplicate_bug_id  %]
>+          of [% bug_id FILTER bug_link("Bug $bug_id") %]

This is a bit confusing; better to just use bug.dup_id in both places, rather
than have a local. Or, rename the local to something like dup_id.

>+        [% END %]
>+      </td>      

Nit: no capital b on Bug, as it's not the beginning of a sentence. (We may get
this wrong elsewhere; that's no excuse. :-)

Gerv

Comment 19

[Bradley Baetz (:bbaetz)]

bug.dup id won't work inside the string - you'd hve to concatenate, or use
${bug.dup_id} (I _think_ that that works) which isn't as nice.

Comment 20

[Tobias Burnus]

Attachment: v2.0.3: Review nits fixed.

Comment 21

[Bradley Baetz (:bbaetz)]

Comment on attachment 119726 [details] [diff] [review]
v2.0.3: Review nits fixed.

r=bbaetz. Looks nice, works, etc.

However, that FILTER should be the other way arround - we filter the _text_ by
applying a link to the particular bug.

I stuffed up the code in Bugzilla/Template.pm - GetBugLink takes the bug# as
the first item, not the text. The only other user of this happens to just
linkify the number, so I never noticed. Oops.

Eitehr fix that too, or don't, and I'll file a bug when this gets checked in.

Comment 22

[Tobias Burnus]

> I stuffed up the code in Bugzilla/Template.pm - GetBugLink takes the bug# as
> the first item, not the text.
> Eitehr fix that too, or don't, and I'll file a bug when this gets checked in.

I will fix this; the check-in will contain these extra changes (compared to
attachment 119726 [details] [diff] [review]):

++++ Bugzilla/Template.pm       8 Apr 2003 11:15:18 -0000
+-                                  return &::GetBugLink($text, $bug);
++                                  return &::GetBugLink($bug, $text);
++++ template/en/default/bug/edit.html.tmpl     8 Apr 2003 11:15:18 -0000
-+          of [% bug.dup_id FILTER bug_link("bug ${bug.dup_id}") %]
++          of [% "bug ${bug.dup_id}" FILTER bug_link(bug.dup_id) %]

Comment 23

[Tobias Burnus]

FIXED. I could swear that I'd clicked on Commit yesterday...
Checked in:
 mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl 1.32
 mozilla/webtools/bugzilla/Bugzilla/Template.pm 1.4
 mozilla/webtools/bugzilla/Bug.pm 1.31

Comment 24

[victory <[e-mail]>]

Attachment: docs patch about 'Bugzilla Database Tables' section, for 2.18

Comment 25

[timeless]

Comment on attachment 214029 [details] [diff] [review]
docs patch about 'Bugzilla Database Tables' section, for 2.18

which bugs are duplicates of which other bugs.