717902 - Form autocomplete pop-up with the available suggestions is not displayed in landscape mode when HKB is used

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Carla Nadastean]

Build: Fennec/12.0a1 (2012-01-13)
HTC Desire Z (Android 2.3)

Steps to reproduce:
1. Open Fennec app in landscape mode.
2. Navigate to http://mail.yahoo.com
3. Fill in username and password. (e.g [e-mail]) (Select "Never" or "Not Now" option for Remember password pop-up)
4. Sign out and go back to http://mail.yahoo.com .
5. Try to fill in the same username using the HKB (carla_test)

Expected Result:
Form autocomplete pop-up with the available suggestions is displayed.

Actual Result: 
Form autocomplete pop-up with the available suggestions is not displayed.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Probably a regression from bug 715889. It would seem that mIMELandscapeFS is true even for hardward keyboards.

Maybe using imm.isFullscreenMode() is a better approach?
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AwesomeBar.java#176

Comment 2

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> Probably a regression from bug 715889. It would seem that mIMELandscapeFS is
> true even for hardward keyboards.
> 
> Maybe using imm.isFullscreenMode() is a better approach?
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AwesomeBar.
> java#176

I only have a phone with a virtual keyboard (Motorola Atrix w/ Android 2.3), but when I tried this it was returning true in landscape mode when my keyboard wasn't in fullscreen mode.

However, GeckoInputConnection.mIMELandscapeFS is correctly returning false for me in landscape mode. Is it possible that field could be broken for hardware keyboards?

Comment 3

[Alex Pakhotin (:alexp)]

(In reply to Margaret Leibovic [:margaret] from comment #2)

> However, GeckoInputConnection.mIMELandscapeFS is correctly returning false
> for me in landscape mode. Is it possible that field could be broken for
> hardware keyboards?

This field is a hint for the IME - when a VKB is displayed, this flag controls if it should be fullscreen or not. But when HKB is used, the VKB is hidden, so this flag is just not used. Mark is right - I believe you should use imm.isFullscreenMode() to check for the actual VKB state.

Comment 4

[:Margaret Leibovic]

(In reply to Alex Pakhotin (:alexp) from comment #3)
> (In reply to Margaret Leibovic [:margaret] from comment #2)
> 
> > However, GeckoInputConnection.mIMELandscapeFS is correctly returning false
> > for me in landscape mode. Is it possible that field could be broken for
> > hardware keyboards?
> 
> This field is a hint for the IME - when a VKB is displayed, this flag
> controls if it should be fullscreen or not. But when HKB is used, the VKB is
> hidden, so this flag is just not used. Mark is right - I believe you should
> use imm.isFullscreenMode() to check for the actual VKB state.

Ah, okay. Do you know what could be causing imm.isFullscreenMode() to return true when I'm in landscape mode with a VKB that isn't actually in fullscreen mode?

Comment 5

[Alex Pakhotin (:alexp)]

Attachment: Fix

Use InputMethodManager.isFullscreenMode() to check for the fullscreen VKB mode.

Comment 6

[Alex Pakhotin (:alexp)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e25139fcf302

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/e25139fcf302

Comment 8

[Carla Nadastean]

Verified on: 
2012-01-18 Firefox/12.0a1 Fennec/12.0a

Bug no longer reproducible on Nightly.

Comment 9

[Alex Pakhotin (:alexp)]

Comment on attachment 589079 [details] [diff] [review]
Fix

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Form autocomplete pop-up does not show in landscape with HKB.
Testing completed (on m-c, etc.): Verified on Nightly.
Risk to taking this patch (and alternatives if risky): Low. The change is local and small.

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 589079 [details] [diff] [review]
Fix

[Triage Comment]
Mobile only - approved for Aurora.