Last Comment Bug 718026 - Only walk the stack on profiling builds
: Only walk the stack on profiling builds
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla12
Assigned To: :Ehsan Akhgari (busy, don't ask for review please)
:
Mentors:
Depends on:
Blocks: 713227
  Show dependency treegraph
 
Reported: 2012-01-13 12:27 PST by :Ehsan Akhgari (busy, don't ask for review please)
Modified: 2012-01-17 17:51 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (1012 bytes, patch)
2012-01-13 12:28 PST, :Ehsan Akhgari (busy, don't ask for review please)
jmuizelaar: review+
Details | Diff | Review

Description :Ehsan Akhgari (busy, don't ask for review please) 2012-01-13 12:27:57 PST
Walking the stack on other builds can be dangerous (if the backtrace method is dumb enough to crash us) or useless (if we get partial stacks), so let's do this for profiling builds only for now.
Comment 1 :Ehsan Akhgari (busy, don't ask for review please) 2012-01-13 12:28:47 PST
Created attachment 588493 [details] [diff] [review]
Patch (v1)
Comment 2 :Ehsan Akhgari (busy, don't ask for review please) 2012-01-17 10:15:00 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/39296dfa2ac6
Comment 3 Joe Drew (not getting mail) 2012-01-17 17:51:48 PST
https://hg.mozilla.org/mozilla-central/rev/39296dfa2ac6

Note You need to log in before you can comment on or make changes to this bug.