Closed Bug 718032 Opened 13 years ago Closed 12 years ago

Make stackwalking for other threads cheaper on Windows by avoiding involving a third walker thread

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Patch (v1)
4.55 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
NS_StackWalk for other threads on Windows needs to be as cheap as possible, since we use it in the built-in profiler (bug 718025).

I have a patch which avoids the overhead of using a third thread if we are walking the stack of another thread.
Attached patch Patch (v1) — — Splinter Review 
Assignee: nobody → ehsan
Status: NEW → ASSIGNED

        Attachment #588498 -
        Flags: review?(dbaron)

    
    

    
  
Ignore that last comment, wrong bug #

    
    

    
  
It would be nice if you found somebody else to review this (preferably somebody who does fewer reviews).

    
    

    
  
Comment on attachment 588498 [details] [diff] [review]
Patch (v1)

Sure.  Jeff, wanna take a stab at this?

        Attachment #588498 -
        Flags: review?(dbaron) → review?(jmuizelaar)

        Attachment #588498 -
        Flags: review?(jmuizelaar) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/688b672929ca
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: