Closed
Bug 718032
Opened 14 years ago
Closed 14 years ago
Make stackwalking for other threads cheaper on Windows by avoiding involving a third walker thread
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
4.55 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
NS_StackWalk for other threads on Windows needs to be as cheap as possible, since we use it in the built-in profiler (bug 718025).
I have a patch which avoids the overhead of using a third thread if we are walking the stack of another thread.
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Comment 2•14 years ago
|
||
|
|
||
Comment 3•14 years ago
|
||
Ignore that last comment, wrong bug #
It would be nice if you found somebody else to review this (preferably somebody who does fewer reviews).
|
|
Assignee | |
Comment 5•14 years ago
|
||
Comment on attachment 588498 [details] [diff] [review]
Patch (v1)
Sure. Jeff, wanna take a stab at this?
Attachment #588498 -
Flags: review?(dbaron) → review?(jmuizelaar)
|
||
Updated•14 years ago
|
Attachment #588498 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
||
Comment 7•14 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•