The default bug view has changed. See this FAQ.

Make stackwalking for other threads cheaper on Windows by avoiding involving a third walker thread

RESOLVED FIXED in mozilla12

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla12
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
NS_StackWalk for other threads on Windows needs to be as cheap as possible, since we use it in the built-in profiler (bug 718025).

I have a patch which avoids the overhead of using a third thread if we are walking the stack of another thread.
(Assignee)

Comment 1

5 years ago
Created attachment 588498 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #588498 - Flags: review?(dbaron)
https://hg.mozilla.org/integration/mozilla-inbound/rev/1240ddec34af
Ignore that last comment, wrong bug #
It would be nice if you found somebody else to review this (preferably somebody who does fewer reviews).
(Assignee)

Comment 5

5 years ago
Comment on attachment 588498 [details] [diff] [review]
Patch (v1)

Sure.  Jeff, wanna take a stab at this?
Attachment #588498 - Flags: review?(dbaron) → review?(jmuizelaar)
Attachment #588498 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/688b672929ca
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/688b672929ca
You need to log in before you can comment on or make changes to this bug.