71822 - Can not view page source code

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Tracy Walker [:tracy]]

seen on linux commercial build 2001-03-13-05-mtrunk
 
-browse a page
-attempt to view page source with View | Page Source

a new window is not opened with the source code as expected.

Comment 1

[Asa Dotzler [:asa]]

reassigning

Comment 2

[Jeffrey Baker]

Also broken on mozilla builds.  Console:

JavaScript error: 
chrome://navigator/content/navigator.js line 1018: focusedWindow has no properties

Comment 3

[R.K.Aa.]

View source worked OK on a linux CVS build w/changes up through 03/13/2001 00:39

Comment 4

[Paul Chen]

R.K.Aa, thanks, appreciate the info.

Comment 5

[Paul Chen]

Just tested mac build 2001031309, and view source works. Interesting...

Comment 6

[Paul Chen]

Also, there is no js warning at navigator.js, line 1018 on the mac.

Comment 7

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I pulled this morning, and I see the same JS warning (and view source not
working) on NT. Happens with both keyboard shortcut and menus. Changing OS to all.

I found a workaround: type "javascript:1" + ENTER in the URL bar. After that
View Source works normally.

Comment 8

[Heikki Toivonen (remove -bugzilla when emailing directly)]

AO=All for real...

Comment 9

[Alec Flett]

Attachment: can't we just do this for now?

Comment 10

[Paul Chen]

Well, only the edit to navigator.js ;-) Ok, though it's kinda funny, but
patch=alecf, r=pchen

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Yeah, not sure what the <offline-indicator stuff is, but if a XUL tag isn't 
properly set up with a display type or XBL binding etc, you get warnings about 
unknown frame type. a=ben for the navigator.js part. 

Comment 12

[Tracy Walker [:tracy]]

seeing this also on Mac 2001-03-13-10-trunk

was able to view page source at first, but once I tried to view an international 
page this became broken.  (at least that seems to be what broke it)

Comment 13

[Paul Chen]

Alec has checked in the workaround. Marking fixed.

Comment 14

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Um, isn't the fix wrong? You've now scoped the declaration of docCharset so that
what you will pass into openDialog will always be undefined! If you see it
working it is perhaps because you are viewing pages where the charset matches
our defaults... Reopening.

Comment 15

[Alec Flett]

no! javascript has function-scoped variables... it doesn't matter if it's
declared in the if

Comment 16

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Doh... one of these days I should read a JS book I guess...

Comment 17

[sairuh (rarely reading bugmail)]

vrfy fixed using 2001.03.21.08 comm bits on the 3 main platforms.