718235 - [SeaMonkey] "a11y/accessible/events/test_focus_general.html | Doubled event { event type: focus, target: 'link'} in test with ID = ' 'link' 'tab shift ' key'."

Status: RESOLVED WORKSFORME

(Core :: Disability Access APIs, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120104 Firefox/12.0a1 SeaMonkey/2.9a1]
{
45 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/even
ts/test_focus_general.html | Doubled event { event type: focus, target:  'link'
} in test with ID = ' 'link'  'tab shift ' key'.
}

Reproducible when running the "full" suite or the test alone.

NB:
Bug 684818 reactivated this test (except on Linux).
And a11y tests are not run on OSX.

Comment 1

[Serge Gautherie (:sgautherie)]

Code is
{
109       if (LINUX)
110         todo(false, "shift tab from editable document Fails on linux!");
111       else
112         gQueue.push(new synthShiftTab("link", new focusChecker("link")));
}

Comment 2

[[e-mail]]

Interesting... if I click on the design mode frame, the focused element is null, and if I then shift+tab, the focused element is the HTML element, and if I shift+tab again then I get taken to the previous link element. Trying this in a general design mode frame case, SeaMonkey 2.1 also does this, while SeaMonkey 1.5a does not; there design mode frame document elements never have focus.

I can also reproduce this behaviour with design mode documents in Firefox, so I don't know why the test passes there at all.

Comment 3

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1329726992.1329731718.29744.gz
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/02/20 00:36:32
{
2940 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/events/test_focus_general.html | Doubled event { event type: focus, target:  'link' } in test with ID = ' 'link'  'tab shift ' key'.
}

Comment 4

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1330071749.1330076464.18395.gz
WINNT 5.2 comm-aurora debug test mochitest-other on 2012/02/24 00:22:29

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1330085913.1330089588.19091.gz
WINNT 5.2 comm-beta debug test mochitest-other on 2012/02/24 04:18:33

SM 2.9 and 2.8 are already affected.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) events/test_focus_general.html: Disable synthShiftTab() check on SeaMonkey [Checked in: Comments 7 and 15]

Workaround until we have a fix.

Comment 6

[alexander :surkov (:asurkov)]

Comment on attachment 600415 [details] [diff] [review]
(Av1) events/test_focus_general.html: Disable synthShiftTab() check on SeaMonkey
[Checked in: Comments 7 and 15]

Review of attachment 600415 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/events/test_focus_general.html
@@ +112,2 @@
>        if (LINUX)
> +        todo(false, "shift tab from editable document fails on linux!");

maybe
if (SEAMONKEY || LINUX)
  todo(false, "shitf tab ... fails on linux and seamonkey (bug number)");
else
  gQueue.push()

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 600415 [details] [diff] [review]
(Av1) events/test_focus_general.html: Disable synthShiftTab() check on SeaMonkey
[Checked in: Comments 7 and 15]

https://hg.mozilla.org/mozilla-central/rev/7cb1e4c50145


(In reply to alexander :surkov from comment #6)
> if (SEAMONKEY || LINUX)
>   todo(false, "shitf tab ... fails on linux and seamonkey (bug number)");

I would rather not, because the issue are (assumed) not related:
*SeaMonkey should be temporary, though no ETA atm.
*Linux was added is bug 684818 comment 9, but no follow-up was filed (yet).

***

[Approval Request Comment]
Regression caused by (bug #): Bug 684818.
User impact if declined: None, but perma-orange on SeaMonkey.
Testing completed (on m-c, etc.): This comment.
Risk to taking this patch (and alternatives if risky): None, test only.
String changes made by this patch: None.

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Serge Gautherie (:sgautherie) from comment #7)
> Comment on attachment 600415 [details] [diff] [review]
> (Av1) events/test_focus_general.html: Disable synthShiftTab() check on
> SeaMonkey
> [Checked in: Comment 7]
> 
> https://hg.mozilla.org/mozilla-central/rev/7cb1e4c50145
> 
> 
> (In reply to alexander :surkov from comment #6)
> > if (SEAMONKEY || LINUX)
> >   todo(false, "shitf tab ... fails on linux and seamonkey (bug number)");
> 
> I would rather not, because the issue are (assumed) not related:
> *SeaMonkey should be temporary, though no ETA atm.
> *Linux was added is bug 684818 comment 9, but no follow-up was filed (yet).

maybe they aren't related, dunno. We need to keep that todo for both cases anyway so keeping them under same 'if' statement makes the code looks a little bit nicer. up to you.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to alexander :surkov from comment #8)
> maybe they aren't related, dunno. We need to keep that todo for both cases
> anyway so keeping them under same 'if' statement makes the code looks a
> little bit nicer. up to you.

I agree wrt code niceness, but we usually try to keep SeaMonkey hacks separate to ease tracking (code, approvals, ...): I pushed it as is.

Comment 10

[[e-mail]]

This test doesn't work in my Firefox build either. I also noticed that clicking the design mode frame resets the focused element to null, but tabbing to it sets it to the root element. I also see an incorrect comment in the event state manager which claims that an element in a design mode document won't report as editable. (I can't tell whether the code actually wants it to or not.)

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to [e-mail] from comment #10)

> This test doesn't work in my Firefox build either.

[Mozilla/5.0 (Windows NT 5.0; rv:13.0a1) Gecko/20120201 Firefox/13.0a1] (nightly, 2012-02-01-03-11-46-mozilla-central)

Ftr, WorksForMe in that build.

> I also noticed that
> clicking the design mode frame resets the focused element to null, but
> tabbing to it sets it to the root element. I also see an incorrect comment
> in the event state manager which claims that an element in a design mode
> document won't report as editable. (I can't tell whether the code actually
> wants it to or not.)

Should you file a blocking bug?

Comment 12

[[e-mail]]

D'oh, I don't think I had followed the test steps correctly - the test now works (standalone) for me in both SeaMonkey and Firefox on Windows...

Comment 13

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #0)
> Reproducible when running the "full" suite or the test alone.

(In reply to [e-mail] from comment #12)
> D'oh, I don't think I had followed the test steps correctly - the test now
> works (standalone) for me in both SeaMonkey and Firefox on Windows...

[Mozilla/5.0 (Windows NT 5.0; rv:13.0a1) Gecko/20120201 Firefox/13.0a1 SeaMonkey/2.10a1] (nightly, 2012-02-01-00-30-09-comm-central-trunk)

Ftr, the "link" is focused as expected, but the test reports the doubled event.

Comment 14

[Alex Keybl [:akeybl]]

Comment on attachment 600415 [details] [diff] [review]
(Av1) events/test_focus_general.html: Disable synthShiftTab() check on SeaMonkey
[Checked in: Comments 7 and 15]

[Triage Comment]
Test only change - approved for Aurora 12 and Beta 11.

Comment 15

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 600415 [details] [diff] [review]
(Av1) events/test_focus_general.html: Disable synthShiftTab() check on SeaMonkey
[Checked in: Comments 7 and 15]

http://hg.mozilla.org/releases/mozilla-aurora/rev/1334274e439c
http://hg.mozilla.org/releases/mozilla-beta/rev/4dba2b01138a

Comment 16

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1330574925.1330581683.17190.gz
WINNT 5.2 comm-aurora debug test mochitest-other on 2012/02/29 20:08:45

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1330553750.1330557889.10387.gz
WINNT 5.2 comm-beta debug test mochitest-other on 2012/02/29 14:15:50

seamonkey2.9 and seamonkey2.8: verified.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:Jamie, could you have a look please?

For more information, please visit BugBot documentation.