Closed
Bug 718258
Opened 14 years ago
Closed 13 years ago
nsToolkitCompsCID.h: unduplicate NS_AUTOCOMPLETECONTROLLER_CONTRACTID
Categories
(Toolkit :: Autocomplete, defect)
Toolkit
Autocomplete
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: sgautherie, Assigned: prip)
References
()
Details
(Keywords: regression, Whiteboard: [good first bug])
Attachments
(1 file)
|
1017 bytes,
patch
|
benjamin
:
review+
sgautherie
:
feedback+
|
Details | Diff | Splinter Review |
{
48 #define NS_AUTOCOMPLETECONTROLLER_CONTRACTID \
49 "@mozilla.org/autocomplete/controller;1"
50
51 #define NS_AUTOCOMPLETECONTROLLER_CONTRACTID \
52 "@mozilla.org/autocomplete/controller;1"
}
Bug 215467 duplicated it :-(
Flags: in-testsuite-
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → thomas
|
Reporter | |
Updated•14 years ago
|
Attachment #588977 -
Flags: review?(benjamin)
Attachment #588977 -
Flags: feedback+
|
||
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•14 years ago
|
Attachment #588977 -
Flags: review?(benjamin) → review+
|
||
Comment 2•13 years ago
|
||
I'm looking at old "good first bugs" not touched for a while. I've noticed this one that already has a review "+" and feedback "+" flags.
Benjamin, is there something blocking this bug?
Flags: needinfo?(benjamin)
|
|
||
Comment 3•13 years ago
|
||
No. prip, for future reference the person who wrote the patch is normally responsible for getting it committed. See https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree for details about using checkin-needed for that.
Flags: needinfo?(benjamin)
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•