718258 - nsToolkitCompsCID.h: unduplicate NS_AUTOCOMPLETECONTROLLER_CONTRACTID

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Serge Gautherie (:sgautherie)]

{
48 #define NS_AUTOCOMPLETECONTROLLER_CONTRACTID \
49   "@mozilla.org/autocomplete/controller;1"
50 
51 #define NS_AUTOCOMPLETECONTROLLER_CONTRACTID \
52   "@mozilla.org/autocomplete/controller;1"
}

Bug 215467 duplicated it :-(

Comment 1

[Thomas Prip Vestergaard [:prip]]

Attachment: Remove duplicate code

Comment 2

[Tiziana Sellitto [:tiziana]]

I'm looking at old "good first bugs" not touched for a while. I've noticed this one that already has a review "+" and feedback "+" flags.
Benjamin, is there something blocking this bug?

Comment 3

[Benjamin Smedberg]

No. prip, for future reference the person who wrote the patch is normally responsible for getting it committed. See https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree for details about using checkin-needed for that.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04c60abd331d

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/04c60abd331d