nsToolkitCompsCID.h: unduplicate NS_AUTOCOMPLETECONTROLLER_CONTRACTID

RESOLVED FIXED in mozilla24

Status

()

Toolkit
Autocomplete
--
trivial
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: prip)

Tracking

({regression})

Trunk
mozilla24
regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug], URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
{
48 #define NS_AUTOCOMPLETECONTROLLER_CONTRACTID \
49   "@mozilla.org/autocomplete/controller;1"
50 
51 #define NS_AUTOCOMPLETECONTROLLER_CONTRACTID \
52   "@mozilla.org/autocomplete/controller;1"
}

Bug 215467 duplicated it :-(
Flags: in-testsuite-
(Assignee)

Comment 1

6 years ago
Created attachment 588977 [details] [diff] [review]
Remove duplicate code
(Assignee)

Updated

6 years ago
Assignee: nobody → thomas
(Reporter)

Updated

6 years ago
Attachment #588977 - Flags: review?(benjamin)
Attachment #588977 - Flags: feedback+

Updated

6 years ago
Status: NEW → ASSIGNED

Updated

6 years ago
Attachment #588977 - Flags: review?(benjamin) → review+
I'm looking at old "good first bugs" not touched for a while. I've noticed this one that already has a review "+" and feedback "+" flags.
Benjamin, is there something blocking this bug?
Flags: needinfo?(benjamin)

Comment 3

5 years ago
No. prip, for future reference the person who wrote the patch is normally responsible for getting it committed. See https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree for details about using checkin-needed for that.
Flags: needinfo?(benjamin)
Keywords: checkin-needed

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/04c60abd331d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.