Last Comment Bug 718324 - [Linux, QT] "Warning: package error or possible missing or unnecessary file: bin/chrome/icons/default/default16.png (package-manifest, 315)." (+ 2 more)
: [Linux, QT] "Warning: package error or possible missing or unnecessary file: ...
Status: VERIFIED FIXED
:
Product: Firefox
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: x86 Linux
: P1 normal (vote)
: Firefox 13
Assigned To: Serge Gautherie (:sgautherie)
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: 511642 713132
  Show dependency treegraph
 
Reported: 2012-01-15 12:37 PST by Serge Gautherie (:sgautherie)
Modified: 2012-02-22 19:15 PST (History)
2 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
wontfix
wontfix
wontfix
verified
affected


Attachments
(Av1) Fix condition for packaging 'default*.png' [Checked in: Comments 3 and 6] (1014 bytes, patch)
2012-01-29 07:25 PST, Serge Gautherie (:sgautherie)
ted: review+
akeybl: approval‑mozilla‑aurora+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2012-01-15 12:37:25 PST
https://tbpl.mozilla.org/php/getParsedLog.php?id=8566753&tree=Try&full=1
Linux QT try build on 2012-01-15 09:28:37 PST for push 0f7ff1139bde
[
Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/default16.png (package-manifest, 315).
Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/default32.png (package-manifest, 316).
Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/default48.png (package-manifest, 317).
}

NB: It's an error in this log, because I was checking bug 713132.
Comment 1 Serge Gautherie (:sgautherie) 2012-01-29 07:25:22 PST
Created attachment 592502 [details] [diff] [review]
(Av1) Fix condition for packaging 'default*.png'
[Checked in: Comments 3 and 6]
Comment 2 Serge Gautherie (:sgautherie) 2012-02-05 06:34:28 PST
Ping for review.
Comment 3 Serge Gautherie (:sgautherie) 2012-02-13 14:27:26 PST
Comment on attachment 592502 [details] [diff] [review]
(Av1) Fix condition for packaging 'default*.png'
[Checked in: Comments 3 and 6]

https://hg.mozilla.org/mozilla-central/rev/882cb76f5b34


[Approval Request Comment]
Regression caused by (bug #): (old)
User impact if declined: None, but ("last" to) blocks bug 713132.
Testing completed (on m-c, etc.): this comment.
Risk to taking this patch (and alternatives if risky): None.
String changes made by this patch: None.
Comment 4 Serge Gautherie (:sgautherie) 2012-02-13 15:37:43 PST
https://tbpl.mozilla.org/php/getParsedLog.php?id=9304724&tree=Firefox&full=1
Linux QT mozilla-central build on 2012-02-13 14:07:54 PST for push 882cb76f5b34

V.Fixed
Comment 5 Alex Keybl [:akeybl] 2012-02-14 11:23:57 PST
Comment on attachment 592502 [details] [diff] [review]
(Av1) Fix condition for packaging 'default*.png'
[Checked in: Comments 3 and 6]

[Triage Comment]
Simple, low-risk change early in Aurora 12. Approved.
Comment 6 Jens Hatlak (:InvisibleSmiley) 2012-02-22 09:07:11 PST
Comment on attachment 592502 [details] [diff] [review]
(Av1) Fix condition for packaging 'default*.png'
[Checked in: Comments 3 and 6]

http://hg.mozilla.org/releases/mozilla-aurora/rev/1feee394bb27
Comment 7 Serge Gautherie (:sgautherie) 2012-02-22 19:15:40 PST
https://tbpl.mozilla.org/php/getParsedLog.php?id=9531687&tree=Mozilla-Aurora&full=1
Linux QT mozilla-aurora build on 2012-02-22 09:07:18 PST for push 1feee394bb27

firefox12: verified.

Note You need to log in before you can comment on or make changes to this bug.