Add max tolerance value to fuzzy reftests

RESOLVED FIXED in mozilla12

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

unspecified
mozilla12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 588768 [details] [diff] [review]
Add fuzzy-max option

In some cases we want to support differences in reftests greater than 2 (skia in particular). I feel that it's better to have this configurable rather than disabling the tests entirely.
Attachment #588768 - Flags: review?(dbaron)
I actually think the maximum number of different pixels, and the maximum difference per pixel, should be mandatory parameters to 'fuzzy'/'fuzzy-if'.
(Assignee)

Comment 2

6 years ago
Created attachment 590114 [details] [diff] [review]
Add max values to fuzzy/fuzzy-if instead

Alternative option that roc suggested.
Attachment #590114 - Flags: review?(dbaron)
(Assignee)

Comment 3

6 years ago
Created attachment 590619 [details] [diff] [review]
Add max values to fuzzy/fuzzy-if instead v2

Updated tolerance values to match the failures seen on tinderbox, and updated for new fuzzy tests that have been added since the previous patch was posted.

dbaron: Do you mind if roc reviews this?
Attachment #590114 - Attachment is obsolete: true
Attachment #590114 - Flags: review?(dbaron)
Attachment #590619 - Flags: review?(roc)
Attachment #590619 - Flags: review?(roc) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/05df0cddc299
Assignee: nobody → matt.woodrow

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/05df0cddc299

Presume the other patch is now obsolete?
Status: NEW → RESOLVED
Last Resolved: 6 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
(Assignee)

Updated

6 years ago
Attachment #588768 - Attachment is obsolete: true
Attachment #588768 - Flags: review?(dbaron)
Blocks: 729784
This patch should have updated the documentation.  This has now been reported twice; see bug 729784.
Depends on: 1252361
You need to log in before you can comment on or make changes to this bug.