Closed Bug 718329 Opened 8 years ago Closed 8 years ago

Add max tolerance value to fuzzy reftests

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Add fuzzy-max option (obsolete) — Splinter Review
In some cases we want to support differences in reftests greater than 2 (skia in particular). I feel that it's better to have this configurable rather than disabling the tests entirely.
Attachment #588768 - Flags: review?(dbaron)
I actually think the maximum number of different pixels, and the maximum difference per pixel, should be mandatory parameters to 'fuzzy'/'fuzzy-if'.
Alternative option that roc suggested.
Attachment #590114 - Flags: review?(dbaron)
Updated tolerance values to match the failures seen on tinderbox, and updated for new fuzzy tests that have been added since the previous patch was posted.

dbaron: Do you mind if roc reviews this?
Attachment #590114 - Attachment is obsolete: true
Attachment #590114 - Flags: review?(dbaron)
Attachment #590619 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/05df0cddc299

Presume the other patch is now obsolete?
Status: NEW → RESOLVED
Closed: 8 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Attachment #588768 - Attachment is obsolete: true
Attachment #588768 - Flags: review?(dbaron)
This patch should have updated the documentation.  This has now been reported twice; see bug 729784.
You need to log in before you can comment on or make changes to this bug.