Last Comment Bug 718329 - Add max tolerance value to fuzzy reftests
: Add max tolerance value to fuzzy reftests
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Matt Woodrow (:mattwoodrow)
:
Mentors:
Depends on: 1252361 580786
Blocks: 729784
  Show dependency treegraph
 
Reported: 2012-01-15 13:11 PST by Matt Woodrow (:mattwoodrow)
Modified: 2016-02-29 19:56 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add fuzzy-max option (5.53 KB, patch)
2012-01-15 13:11 PST, Matt Woodrow (:mattwoodrow)
no flags Details | Diff | Review
Add max values to fuzzy/fuzzy-if instead (16.88 KB, patch)
2012-01-19 22:42 PST, Matt Woodrow (:mattwoodrow)
no flags Details | Diff | Review
Add max values to fuzzy/fuzzy-if instead v2 (17.48 KB, patch)
2012-01-22 19:38 PST, Matt Woodrow (:mattwoodrow)
roc: review+
Details | Diff | Review

Description Matt Woodrow (:mattwoodrow) 2012-01-15 13:11:43 PST
Created attachment 588768 [details] [diff] [review]
Add fuzzy-max option

In some cases we want to support differences in reftests greater than 2 (skia in particular). I feel that it's better to have this configurable rather than disabling the tests entirely.
Comment 1 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-01-18 17:31:38 PST
I actually think the maximum number of different pixels, and the maximum difference per pixel, should be mandatory parameters to 'fuzzy'/'fuzzy-if'.
Comment 2 Matt Woodrow (:mattwoodrow) 2012-01-19 22:42:56 PST
Created attachment 590114 [details] [diff] [review]
Add max values to fuzzy/fuzzy-if instead

Alternative option that roc suggested.
Comment 3 Matt Woodrow (:mattwoodrow) 2012-01-22 19:38:05 PST
Created attachment 590619 [details] [diff] [review]
Add max values to fuzzy/fuzzy-if instead v2

Updated tolerance values to match the failures seen on tinderbox, and updated for new fuzzy tests that have been added since the previous patch was posted.

dbaron: Do you mind if roc reviews this?
Comment 4 Matt Woodrow (:mattwoodrow) 2012-01-22 23:57:06 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/05df0cddc299
Comment 5 Ed Morley [:emorley] 2012-01-23 11:50:40 PST
https://hg.mozilla.org/mozilla-central/rev/05df0cddc299

Presume the other patch is now obsolete?
Comment 6 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-06-05 14:05:37 PDT
This patch should have updated the documentation.  This has now been reported twice; see bug 729784.

Note You need to log in before you can comment on or make changes to this bug.