729784 - reftest/README.txt needs to document the extra arguments for fuzzy-if() annotations

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Annotate a reftest with fuzzy-if(/^Windows\x20NT\x205\.1/.test(http.oscpu))
     e.g. by applying attachment 598059 [details] [diff] [review]
 2. run reftests
     e.g. TEST_PATH=layout/reftests/svg/smil/reftest.list make reftest

ACTUAL RESULTS:
{
reftest failed:
REFTEST TEST-UNEXPECTED-FAIL | | EXCEPTION: Error 1 in manifest file file:///scratch/work/builds/mozilla-central/mozilla-central.10-11-30.15-47/mozilla/layout/reftests/svg/smil/reftest.list line 125
}

EXPECTED RESULTS:
This syntax should be accepted.  It works fine if I use "fails-if" or "skip-if" instead.

Comment 1

[Daniel Holbert [:dholbert]]

Oh, never mind -- it looks like fuzzy-if just takes more arguments.

Comment 2

[Daniel Holbert [:dholbert]]

...though the fuzzy-if documentation is incorrect -- it says:
> 113       fuzzy-if(condition) If the condition is met, the test is treated as if
> 114                           'fuzzy' had been specified. This is useful if there
> 115                           are differences on particular platforms.
and doesn't mention the other arguments.  Reopening & retargeting this bug on correctly-documenting these argumnents.

http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/README.txt#113

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Fix documentation

Update the docs!

This also changes the data output into reftest logs to match the order required by fuzzy. This should hopefully make things clearer.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 643453 [details] [diff] [review]
Fix documentation

># HG changeset patch
># User Matt Woodrow <[e-mail]>
># Date 1342634117 14400
># Node ID d2ac6eb0759642058790c7745f70df71f855f606
># Parent  f7ce3a0f3d81d9b718a47778f6eefa539b1a3396
>[mq]: fix-fuzzy-docs

How about a commit message like:
  Fix documentation for fuzzy() and fuzzy-if(), and give image difference error messages in the same order as the parameters to them.  (Bug 729784)  r=dbaron


Thanks for fixing this.

r=dbaron

Comment 6

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8253f91b0eef

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8253f91b0eef