nsHTMLTableSectionElement.cpp:188:12: error: variable 'rv' set but not used [-Werror=unused-but-set-variable]

RESOLVED FIXED in mozilla12

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla12
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 588959 [details] [diff] [review]
rv set but not used

Tried to compile FF desktop with default config and warnings as errors param, and got it fail to compile.

most likely blocking bug 698275
Attachment #588959 - Flags: review?(Ms2ger)
(Assignee)

Updated

5 years ago
Summary: Warning as errors, rv set but not used → nsHTMLTableSectionElement.cpp:188:12: error: variable 'rv' set but not used [-Werror=unused-but-set-variable]
Comment on attachment 588959 [details] [diff] [review]
rv set but not used

Please add NS_ENSURE_SUCCESS(rv, rv); after all these assignments instead.
Attachment #588959 - Flags: review?(Ms2ger) → review-
(Assignee)

Comment 2

5 years ago
Created attachment 588990 [details] [diff] [review]
rv set but not used, use it
Assignee: nobody → romaxa
Attachment #588959 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #588990 - Flags: review?(Ms2ger)
Comment on attachment 588990 [details] [diff] [review]
rv set but not used, use it

Looks good, thanks.
Attachment #588990 - Flags: review?(Ms2ger) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 716904
This was pushed to inbound by Ms2ger, then merged to central:

https://hg.mozilla.org/integration/mozilla-inbound/rev/2613bbdae8c6
https://hg.mozilla.org/mozilla-central/rev/2613bbdae8c6
Keywords: checkin-needed
Resolution: DUPLICATE → FIXED
Target Milestone: --- → mozilla12

Updated

5 years ago
Duplicate of this bug: 716904
You need to log in before you can comment on or make changes to this bug.