718615 - 'Clear history' is broken

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Peter Retzer (:pretzer)]

Attachment: Screenshot of the issue

'Clear history' seems to be broken. 

STR:
1. Clear your history from the prefs menu 
2. Make sure the history and top sites list is empty 
3. Visit a site you had in your history before you cleared it 

Expected:
The visited site should show up once inside the history and the top sites lists. 

Actual:
The visited site shows up twice inside the history and top sites lists. 

If you repeat the steps, each time the list will grow by one more history item. See Screenshot...

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Nightly (01/17) - raw log

Nice catch.

I see multiple transactions for a given URI. I tried slashdot.org, and I see it listed three times.

--
Samsung Nexus S (Android 4.0.3)
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120117 Firefox/12.0a1 Fennec/12.0a1

Comment 2

[Lucas Rocha (:lucasr)]

Looks like a serious regression most likely caused by local DB. Setting P1.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

We should fix for Fx11, but not blocking beta 1

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Fix history visit update when dealing with deleted entries

Comment 6

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/091270ee3f13

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 595801 [details] [diff] [review]
Fix history visit update when dealing with deleted entries

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: Clear history causes duplicate entries in history
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/091270ee3f13

Comment 9

[Peter Retzer (:pretzer)]

The patch did indeed fix the issue, thanks! No new duplicate entries appear in the latest nightly build, after clearing history.
But the old duplicate entries, that have pilled up during testing, appear again when visiting one of those sites. Is this intended? I can imagine you don't want to add code just for that, so is there another way to clear those old duplicates?

Comment 10

[Lucas Rocha (:lucasr)]

(In reply to pretzer from comment #9)
> The patch did indeed fix the issue, thanks! No new duplicate entries appear
> in the latest nightly build, after clearing history.
> But the old duplicate entries, that have pilled up during testing, appear
> again when visiting one of those sites. Is this intended? I can imagine you
> don't want to add code just for that, so is there another way to clear those
> old duplicates?

The only way I can think of is to clear the data of Fennec app (from Android settings), which is non-ideal :-/

Comment 11

[Peter Retzer (:pretzer)]

(In reply to Lucas Rocha (:lucasr) from comment #10)
> The only way I can think of is to clear the data of Fennec app (from Android
> settings), which is non-ideal :-/

That worked, thanks!

Comment 12

[Camelia Urian]

Nightly 13.0a1 (2012-02-21)
Device: Samsung Nexus S - Android 2.3.6

Marking as verified fixed on Nightly. If bug won't be fixed on Aurora and Beta, please close bug.

Comment 13

[Alex Keybl [:akeybl]]

Comment on attachment 595801 [details] [diff] [review]
Fix history visit update when dealing with deleted entries

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 14

[Matt Brubeck (:mbrubeck)]

Comment on attachment 595801 [details] [diff] [review]
Fix history visit update when dealing with deleted entries

Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions.  If this changes in the future, we will likely do a mass uplift of all native fennec changes.  For now, let's get these bugs off the channel triage radar.

[Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]

Comment 15

[Camelia Urian]

Marking bug as Verified Fixed based on Comments 12 and 14.