718912 - Port |Bug 717975 - only expose m-c implementation of navigator.mozApps on b2g| to SeaMonkey

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Stop packaging b2g-specific 'Webapps.js'

With removed-files.in part too.

Comment 2

[Justin Wood (:Callek)]

I'm pretty sure you need to removed-files the .manifest and dom_apps, I could be wrong since i'm not looking too closely... but I'll defer real review for a few days.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to Justin Wood (:Callek) from comment #2)
> I'm pretty sure you need to removed-files the .manifest and dom_apps, I
> could be wrong since i'm not looking too closely

I didn't look too closely myself, but aren't .xpt merged into browser.xpt and .manifest into components.manifest?

Comment 4

[Serge Gautherie (:sgautherie)]

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=3097e9c39214
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1326924492.1326931726.27202.gz&fulltext=1
Linux x86-64 try-comm-central leak test build on 2012/01/18 14:08:12
{
Error: package error or possible missing or unnecessary file: bin/components/Webapps.js (package-manifest, 313).
Error: package error or possible missing or unnecessary file: bin/components/Webapps.manifest (package-manifest, 314).
}

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1a) Stop packaging b2g-specific 'Webapps.js[m]' [Checked in: Comments 6 and 10]

Av1, with .jsm part too.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 590209 [details] [diff] [review]
(Av1a) Stop packaging b2g-specific 'Webapps.js[m]'
[Checked in: Comments 6 and 10]

http://hg.mozilla.org/comm-central/rev/76bdaffc721c

Comment 7

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1327610237.1327612673.28151.gz&fulltext=1
Linux x86-64 comm-central-trunk build on 2012/01/26 12:37:17

V.Fixed

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 590209 [details] [diff] [review]
(Av1a) Stop packaging b2g-specific 'Webapps.js[m]'
[Checked in: Comments 6 and 10]

"approval-comm-beta=?":
Per bug 717975 comment 22.

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 590209 [details] [diff] [review]
(Av1a) Stop packaging b2g-specific 'Webapps.js[m]'
[Checked in: Comments 6 and 10]

a+=me assuming serge feels we need this on beta, I did not verify if we do. (though he did request this and write the patch, so I think its a good chance he does) :-)

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 590209 [details] [diff] [review]
(Av1a) Stop packaging b2g-specific 'Webapps.js[m]'
[Checked in: Comments 6 and 10]

http://hg.mozilla.org/releases/comm-beta/rev/5bb78691db0a

Comment 11

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1331098114.1331108574.32664.gz&fulltext=1
WINNT 5.2 comm-beta build on 2012/03/06 21:28:34

No more
{
Warning: package error or possible missing or unnecessary file: bin/components/Webapps.js (package-manifest, 315).
Warning: package error or possible missing or unnecessary file: bin/components/Webapps.manifest (package-manifest, 316).
}

seamonkey2.8: verified.