Closed Bug 718928 Opened 8 years ago Closed 8 years ago

AndroidManifest.xml does not depend on Sync manifest include fragments

Categories

(Firefox for Android :: Android Sync, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox11 --- fixed
fennec + ---

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

This means that an incremental build will not necessarily preprocess a fresh manifest if some of its dependencies change.

This *could* be a cause of Bug 718703.

$ touch mobile/android/sync/manifests/SyncAndroidManifest_activities.xml.in
$ make -C objdir-droid/mobile/android/base -d AndroidManifest.xml
...
Updating goal targets....
Considering target file `AndroidManifest.xml'.
  Considering target file `AndroidManifest.xml.in'.
   Looking for an implicit rule for `AndroidManifest.xml.in'.
   Trying pattern rule with stem `AndroidManifest.xml.in'.
   Trying implicit prerequisite `AndroidManifest.xml.in.c'.
   Trying pattern rule with stem `AndroidManifest.xml.in'.
   Trying implicit prerequisite `AndroidManifest.xml.in.cpp'.
   Trying pattern rule with stem `AndroidManifest.xml.in'.
   Trying implicit prerequisite `AndroidManifest.xml.in.pl'.
   Trying pattern rule with stem `AndroidManifest.xml.in'.
   Trying implicit prerequisite `AndroidManifest.xml.in.sh'.
   Trying pattern rule with stem `AndroidManifest.xml.in'.
   Trying implicit prerequisite `RCS/AndroidManifest.xml.in'.
   No implicit rule found for `AndroidManifest.xml.in'.
   Finished prerequisites of target file `AndroidManifest.xml.in'.
  No need to remake target `AndroidManifest.xml.in'; using VPATH name `/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/AndroidManifest.xml.in'.
 Finished prerequisites of target file `AndroidManifest.xml'.
 Prerequisite `/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/AndroidManifest.xml.in' is older than target `AndroidManifest.xml'.
No need to remake target `AndroidManifest.xml'.
make: `AndroidManifest.xml' is up to date.


Adding an explicit dependency fixes this:

 Finished prerequisites of target file `AndroidManifest.xml'.
 Prerequisite `/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/AndroidManifest.xml.in' is older than target `AndroidManifest.xml'.
 Prerequisite `/Users/rnewman/moz/hg/mozilla-central/mobile/android/sync/manifests/SyncAndroidManifest_activities.xml.in' is newer than target `AndroidManifest.xml'.
 Prerequisite `/Users/rnewman/moz/hg/mozilla-central/mobile/android/sync/manifests/SyncAndroidManifest_permissions.xml.in' is older than target `AndroidManifest.xml'.
 Prerequisite `/Users/rnewman/moz/hg/mozilla-central/mobile/android/sync/manifests/SyncAndroidManifest_services.xml.in' is older than target `AndroidManifest.xml'.
Must remake target `AndroidManifest.xml'.
Attachment #589409 - Flags: review?(blassey.bugs)
Blocks: 718493
Attachment #589409 - Flags: review?(blassey.bugs) → review?(khuey)
tracking-fennec: ? → +
Review ping?
Blocks: 720933
Comment on attachment 589409 [details] [diff] [review]
Proposed patch. v1

Reviewer redirect!
Attachment #589409 - Flags: review?(khuey) → review?(blassey.bugs)
Comment on attachment 589409 [details] [diff] [review]
Proposed patch. v1

Bouncing to whoever can get this reviewed the quickest. blassey nominated you, ted :D
Attachment #589409 - Flags: review?(blassey.bugs) → review?(ted.mielczarek)
Attachment #589409 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/4552b3b13be3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.