The default bug view has changed. See this FAQ.

AndroidManifest.xml does not depend on Sync manifest include fragments

RESOLVED FIXED

Status

Android Background Services
Android Sync
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

unspecified
ARM
Android
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed, fennec+)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This means that an incremental build will not necessarily preprocess a fresh manifest if some of its dependencies change.

This *could* be a cause of Bug 718703.

$ touch mobile/android/sync/manifests/SyncAndroidManifest_activities.xml.in
$ make -C objdir-droid/mobile/android/base -d AndroidManifest.xml
...
Updating goal targets....
Considering target file `AndroidManifest.xml'.
  Considering target file `AndroidManifest.xml.in'.
   Looking for an implicit rule for `AndroidManifest.xml.in'.
   Trying pattern rule with stem `AndroidManifest.xml.in'.
   Trying implicit prerequisite `AndroidManifest.xml.in.c'.
   Trying pattern rule with stem `AndroidManifest.xml.in'.
   Trying implicit prerequisite `AndroidManifest.xml.in.cpp'.
   Trying pattern rule with stem `AndroidManifest.xml.in'.
   Trying implicit prerequisite `AndroidManifest.xml.in.pl'.
   Trying pattern rule with stem `AndroidManifest.xml.in'.
   Trying implicit prerequisite `AndroidManifest.xml.in.sh'.
   Trying pattern rule with stem `AndroidManifest.xml.in'.
   Trying implicit prerequisite `RCS/AndroidManifest.xml.in'.
   No implicit rule found for `AndroidManifest.xml.in'.
   Finished prerequisites of target file `AndroidManifest.xml.in'.
  No need to remake target `AndroidManifest.xml.in'; using VPATH name `/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/AndroidManifest.xml.in'.
 Finished prerequisites of target file `AndroidManifest.xml'.
 Prerequisite `/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/AndroidManifest.xml.in' is older than target `AndroidManifest.xml'.
No need to remake target `AndroidManifest.xml'.
make: `AndroidManifest.xml' is up to date.


Adding an explicit dependency fixes this:

 Finished prerequisites of target file `AndroidManifest.xml'.
 Prerequisite `/Users/rnewman/moz/hg/mozilla-central/mobile/android/base/AndroidManifest.xml.in' is older than target `AndroidManifest.xml'.
 Prerequisite `/Users/rnewman/moz/hg/mozilla-central/mobile/android/sync/manifests/SyncAndroidManifest_activities.xml.in' is newer than target `AndroidManifest.xml'.
 Prerequisite `/Users/rnewman/moz/hg/mozilla-central/mobile/android/sync/manifests/SyncAndroidManifest_permissions.xml.in' is older than target `AndroidManifest.xml'.
 Prerequisite `/Users/rnewman/moz/hg/mozilla-central/mobile/android/sync/manifests/SyncAndroidManifest_services.xml.in' is older than target `AndroidManifest.xml'.
Must remake target `AndroidManifest.xml'.
(Assignee)

Comment 1

5 years ago
Created attachment 589409 [details] [diff] [review]
Proposed patch. v1
Attachment #589409 - Flags: review?(blassey.bugs)
(Assignee)

Updated

5 years ago
Blocks: 718493
Attachment #589409 - Flags: review?(blassey.bugs) → review?(khuey)

Updated

5 years ago
tracking-fennec: ? → +
(Assignee)

Comment 2

5 years ago
Review ping?
(Assignee)

Updated

5 years ago
Blocks: 720933
(Assignee)

Comment 3

5 years ago
Comment on attachment 589409 [details] [diff] [review]
Proposed patch. v1

Reviewer redirect!
Attachment #589409 - Flags: review?(khuey) → review?(blassey.bugs)
(Assignee)

Comment 4

5 years ago
Comment on attachment 589409 [details] [diff] [review]
Proposed patch. v1

Bouncing to whoever can get this reviewed the quickest. blassey nominated you, ted :D
Attachment #589409 - Flags: review?(blassey.bugs) → review?(ted.mielczarek)
Attachment #589409 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 5

5 years ago
Inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/c93a18bfceee
Whiteboard: [inbound]
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4552b3b13be3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/b314edef7cbf
status-firefox11: --- → fixed
Whiteboard: [inbound]

Updated

5 years ago
Whiteboard: [qa-]
Component: Android Sync → Android Sync
Product: Mozilla Services → Android Background Services
You need to log in before you can comment on or make changes to this bug.