719026 - Blue background color remains for inputs, links etc, when panning inside iframes

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, steps to reproduce:
- Make a swipe movement over one of the iframes

Expected result:
- Content becomes (perhaps) for a short while blue, then is white again

Actual result:
- Content stays light blue (which happens when content like links, text inputs) are css :active when tapped upon.

Tested on the LG Optimus Black on Android 2.2.2 in portrait mode.

I guess this might be related to bug 719019.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase2, using inputs

This bug can also be seen in XUL Fennec, btw.

Also, long tap -> Context Menu -> Paste, then the input in the iframe still stays blue.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Yeah, it does look related to bug 719019/bug 716863 in that some of the events go to the iframe and some do not.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

over to margaret assuming this is related to the iframe event issues she's been working on

Comment 4

[:Margaret Leibovic]

Attachment: patch

A lot has changed since this bug was filed, but I think this patch fixes the problem. In _cancelTapHighlight, we're trying to remove the active state on an element by setting the active state on the top-level document. However, this does not affect the active state set on elements in iframes. To fix that, we need to set the active state on that element's owner document.

I found that with this change, it seems like we remove the highlight too quickly, maybe exposing a problem with how soon we call _cancelTapHighlight, but I'm not sure what the expected behavior is here.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2d50843d2a5

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a2d50843d2a5