Tilt should use the new Highlighter API

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

12 Branch
Firefox 13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tilt])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
(Assignee)

Comment 1

5 years ago
Created attachment 592519 [details] [diff] [review]
v1

There is one line change in inspector.jsm.
I moved "this.highlighter.highlight();" before sending the OPENED notification, because when switching tabs, Tilt needs to call "this.highlighter.hide();". If this hide() call is made before the highlight() action, it won't have any effect because line 293 in highlighter.jsm: "if (this.hidden) return;". This means that the "hidden" flag isn't updated to false when the OPENED observer in Tilt calls hide(), which makes the highlighter always show above Tilt when switching tabs.
This behavior wasn't present before because I was setting the actual highlighter-container display to "none", a state which isn't modified by the highlighter internally.
(Assignee)

Comment 2

5 years ago
Comment on attachment 592519 [details] [diff] [review]
v1

https://tbpl.mozilla.org/?tree=Try&rev=ce9d3ecd89e5
Attachment #592519 - Flags: review?(rcampbell)
(Assignee)

Updated

5 years ago
Depends on: 715970
(Assignee)

Updated

5 years ago
Blocks: 723435
Attachment #592519 - Flags: review?(rcampbell) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [tilt] → [tilt][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/e71292cac3d2
Whiteboard: [tilt][land-in-fx-team] → [tilt][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e71292cac3d2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.