Closed
Bug 719042
Opened 13 years ago
Closed 13 years ago
Tilt should use the new Highlighter API
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: vporof, Assigned: vporof)
References
Details
(Whiteboard: [tilt])
Attachments
(1 file)
|
2.76 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
|
|
Assignee | |
Comment 1•13 years ago
|
||
There is one line change in inspector.jsm.
I moved "this.highlighter.highlight();" before sending the OPENED notification, because when switching tabs, Tilt needs to call "this.highlighter.hide();". If this hide() call is made before the highlight() action, it won't have any effect because line 293 in highlighter.jsm: "if (this.hidden) return;". This means that the "hidden" flag isn't updated to false when the OPENED observer in Tilt calls hide(), which makes the highlighter always show above Tilt when switching tabs.
This behavior wasn't present before because I was setting the actual highlighter-container display to "none", a state which isn't modified by the highlighter internally.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 592519 [details] [diff] [review]
v1
https://tbpl.mozilla.org/?tree=Try&rev=ce9d3ecd89e5
Attachment #592519 -
Flags: review?(rcampbell)
|
||
Updated•13 years ago
|
Attachment #592519 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [tilt] → [tilt][land-in-fx-team]
|
|
||
Comment 3•13 years ago
|
||
Whiteboard: [tilt][land-in-fx-team] → [tilt][fixed-in-fx-team]
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 13
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•