Closed
Bug 723435
Opened 13 years ago
Closed 13 years ago
Properly cleanup enabled vertex attributes after a program is used in Tilt
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: vporof, Assigned: vporof)
References
Details
(Whiteboard: [tilt])
Attachments
(1 file)
|
2.81 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Even if it's currently not necessary, it's always a good idea to clean up after ourselves. Having bindings and settings which persist globally is bad.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
|
|
Assignee | |
Comment 1•13 years ago
|
||
Also removed a couple of unnecessary consts from a worker.
Attachment #593796 -
Flags: review?(rcampbell)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 593796 [details] [diff] [review]
v1
r+ with a try run. I think this'll be ok but just want to make sure.
Attachment #593796 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [tilt] → [tilt][land-in-fx-team]
|
|
||
Comment 4•13 years ago
|
||
Whiteboard: [tilt][land-in-fx-team] → [tilt][fixed-in-fx-team]
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 13
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•