Last Comment Bug 723435 - Properly cleanup enabled vertex attributes after a program is used in Tilt
: Properly cleanup enabled vertex attributes after a program is used in Tilt
Product: Firefox
Classification: Client Software
Component: Developer Tools: Inspector (show other bugs)
: unspecified
: All All
-- normal (vote)
: Firefox 13
Assigned To: Victor Porof [:vporof][:vp]
: Gabriel Luong [:gl][1 biz day review guarantee] (ΦωΦ)
Depends on: 719042
Blocks: 720992
  Show dependency treegraph
Reported: 2012-02-02 01:39 PST by Victor Porof [:vporof][:vp]
Modified: 2012-02-27 01:00 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v1 (2.81 KB, patch)
2012-02-02 05:29 PST, Victor Porof [:vporof][:vp]
rcampbell: review+
Details | Diff | Splinter Review

Description User image Victor Porof [:vporof][:vp] 2012-02-02 01:39:56 PST
Even if it's currently not necessary, it's always a good idea to clean up after ourselves. Having bindings and settings which persist globally is bad.
Comment 1 User image Victor Porof [:vporof][:vp] 2012-02-02 05:29:57 PST
Created attachment 593796 [details] [diff] [review]

Also removed a couple of unnecessary consts from a worker.
Comment 2 User image Rob Campbell [:rc] (:robcee) 2012-02-22 12:34:19 PST
Comment on attachment 593796 [details] [diff] [review]

r+ with a try run. I think this'll be ok but just want to make sure.
Comment 3 User image Victor Porof [:vporof][:vp] 2012-02-23 15:57:45 PST
Comment 4 User image Rob Campbell [:rc] (:robcee) 2012-02-24 06:46:28 PST
Comment 5 User image Tim Taubert [:ttaubert] 2012-02-27 01:00:22 PST

Note You need to log in before you can comment on or make changes to this bug.