719227 - Verify/Implement app status after submission

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

This is another one of those bugs that might be fast if this is already done, but should be verified by a programmer:

- Upon submission, non-paid apps (any of the other three statuses) are put in the review queue and marked as 'frozen'.  The current definition of 'frozen' means they can't appear anywhere featured or on any Top Whatever lists.  If we need to alter that definition later that's fine, but for now just mark it frozen.

- Upon submission, paid apps (only that 1 status) are put in the review queue and are not shown publicly on the site.  Their detail pages work if you go there directly but they aren't in any lists or search results.  Even if someone goes to the detail page the app cannot be bought until it is reviewed.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #0)
> - Upon submission, paid apps (only that 1 status) are put in the review
> queue and are not shown publicly on the site.  Their detail pages work if
> you go there directly but they aren't in any lists or search results.  Even
> if someone goes to the detail page the app cannot be bought until it is
> reviewed.

Currently we disable robots for details pages of unreviewed add-ons. For "frozen" submissions (not sure which `status` that would be) we ensure this is also done for Marketplace templates.

On a related note, other linked pages (e.g., reviews pages) should also be disabled/robot-less - but I'm pretty certain we already do this.

Comment 2

[Wil Clouser [:clouserw]]

Being frozen isn't a status in the ADDON_STATUS sense, it's an entry in the frozen_addons table.  I don't know why it's a table and not a column on the addons table.

Comment 3

[Andy McKay]

I'm not sure why this is on the https://etherpad.mozilla.org/apps-dev-launch, presumably all apps should be going into the same state. Distinguishing between non-paid and paid apps at this point seems out of scope.

Comment 4

[Wil Clouser [:clouserw]]

That makes sense.  I'll remove it from the etherpad.

Comment 5

[Wil Clouser [:clouserw]]

This is worth double checking again now that we're out of the weird detail page restrictions

Comment 6

[Andy McKay]

TBH. Not sure I understand what this is about. I thought I did in chat with Wil, but apparently not.

Comment 7

[krupa raj[:krupa]]

Even free apps which are awaiting review are not listed in browse pages. Should this change?

Comment 8

[Wil Clouser [:clouserw]]

(In reply to Andy McKay [:andym] from comment #6)
> TBH. Not sure I understand what this is about. I thought I did in chat with
> Wil, but apparently not.

Let's talk when you're back next week.

(In reply to krupa raj 82[:krupa] from comment #7)
> Even free apps which are awaiting review are not listed in browse pages.
> Should this change?

Unreviewed apps not showing up in browse pages is fine