Can't publish split native and xul builds under the same product on android market

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
5 years ago
10 months ago

People

(Reporter: catlee, Assigned: blassey)

Tracking

unspecified
Firefox 13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11+ fixed, firefox12 affected, firefox13 fixed, blocking-fennec1.0 beta+, fennec11+)

Details

Attachments

(2 attachments, 4 obsolete attachments)

(Reporter)

Description

5 years ago
I've uploaded both split builds from blassey to the android market under a test product, and am unable to activate both APKs simultaneously. The error is:

"Error: APK version 2012011708 supports all the same devices as other APKs with higher versions. It would not be served. Please deactivate an APK."

version 2012011708 refers to the split xul build.
Created attachment 589981 [details] [diff] [review]
patch

making builds for catlee to test now
Assignee: nobody → blassey.bugs
Created attachment 590240 [details] [diff] [review]
patch
Attachment #589981 - Attachment is obsolete: true
Attachment #590240 - Flags: review?(mbrubeck)
Comment on attachment 590240 [details] [diff] [review]
patch

The android:resizeable attribute is deprecated and was apparently only used in Android 1.6.  I think we can remove it.  (The docs say "You should not use it.")

r=mbrubeck with that change.
Attachment #590240 - Flags: review?(mbrubeck) → review+
Note: *If* we end up *not* shipping the native version alongside the XUL version (say, for Firefox 11), we should make sure this change is backed out of that XUL version for that release.
Nominating for tracking-firefox11 because this patch depends on our go/no-go decision to ship native Fennec.  (See comment 4.)
tracking-fennec: --- → ?
tracking-firefox11: --- → ?

Updated

5 years ago
tracking-firefox11: ? → +
Created attachment 590977 [details] [diff] [review]
patch

this patch will keep trunk installing on all devices while building aurora, beta and release to allow for the split release
Attachment #590240 - Attachment is obsolete: true
Attachment #590977 - Flags: review?(mbrubeck)
(Assignee)

Updated

5 years ago
tracking-fennec: ? → 11+
Priority: -- → P1
Attachment #590977 - Flags: review?(mbrubeck) → review+

Updated

5 years ago
Depends on: 721551

Updated

5 years ago
Keywords: fennecnative-betablocker
Comment on attachment 590977 [details] [diff] [review]
patch

Based on testing in bug 721551, we actually don't need to set xlargeScreens="false" for native Fennec.  So we could leave the native Fennec manifest and configure settings unchanged, and check in only the XUL Fennec changes.

Updated

5 years ago
Status: NEW → ASSIGNED
Flyer is downloading the Native version with the split APK.

Comment 9

5 years ago
(In reply to Naoki Hirata :nhirata from comment #8)
> Flyer is downloading the Native version with the split APK.

That's expected, right? Doesn't it fall under the same criteria as the Kindle Fire and get the phone UI?

Do we have a document full of test results that we can reference and verify?
I've made a document here: https://wiki.mozilla.org/User:MartijnWargers/splitbuild_testing/
Comment on attachment 590977 [details] [diff] [review]
patch

Updated review comments based on new information:

>+++ b/embedding/android/Makefile.in

> ifeq (,$(ANDROID_VERSION_CODE))
>+# decrement the version code by 1 so native fennec will win any compatability ties
>+ANDROID_VERSION_CODE=$(shell echo `$(PYTHON) $(topsrcdir)/toolkit/xre/make-platformini.py --print-buildid | cut -c1-10` - 1 | bc)
>+endif

This should be flipped; the XUL version needs to be higher than the native version.  See bug 721551.

>+++ b/mobile/android/base/AndroidManifest.xml.in

>+#ifdef MOZ_PHONES_ONLY
>+    <supports-screens android:smallScreens="true"
>+                      android:normalScreens="true"
>+                      android:largeScreens="true"
>+                      android:xlargeScreens="false" />
>+#endif

In bug 721551 we found this had no effect on the Market; tablet-only apps are not offered to phones, but phone-only apps are still offered to tablets.  We can remove all the native Fennec parts of this patch, and check in only the XUL fennec changes.

r=mbrubeck with those changes.
https://hg.mozilla.org/integration/mozilla-inbound/rev/934ce089223c
Whiteboard: [inbound]
backed this out because the xul builds were not installing on the tegras and thus all tests were failing for xul builds
Whiteboard: [inbound]
Created attachment 593653 [details] [diff] [review]
patch to not restrict based on OS version

this went ran green on try. The essential change here from the original patch is to not restrict based on OS version. In addition this patch fixes the Makefile logic that was broken in the original patch.
Attachment #590977 - Attachment is obsolete: true
Attachment #593653 - Flags: review?(mbrubeck)
try run: https://tbpl.mozilla.org/?tree=Try&rev=e37c6dc2bcab
Comment on attachment 593653 [details] [diff] [review]
patch to not restrict based on OS version

>+++ b/embedding/android/Makefile.in
> 
>+# decrement the version code by 1 so native fennec will win any compatability ties
>+ANDROID_VERSION_CODE=$(shell echo `$(PYTHON) $(topsrcdir)/toolkit/xre/make-platformini.py --print-buildid | cut -c1-10` + 1 | bc)

Nit: The comment needs to be updated (it's now reversed).
Attachment #593653 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/00d5bbcc98c8
Whiteboard: [inbound]
Comment on attachment 593653 [details] [diff] [review]
patch to not restrict based on OS version

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:
Attachment #593653 - Flags: approval-mozilla-beta?
Attachment #593653 - Flags: approval-mozilla-aurora?
Comment on attachment 593653 [details] [diff] [review]
patch to not restrict based on OS version

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593653 - Flags: approval-mozilla-beta?
Attachment #593653 - Flags: approval-mozilla-beta+
Attachment #593653 - Flags: approval-mozilla-aurora?
Attachment #593653 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/00d5bbcc98c8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/releases/mozilla-aurora/rev/ae27914c62ac
https://hg.mozilla.org/releases/mozilla-beta/rev/33e29c66740d
status-firefox11: --- → fixed
status-firefox12: --- → fixed
status-firefox13: --- → fixed
This broke XUL Fennec browser-chrome tests and reftests on Aurora and Beta (but not on mozilla-central, probably because it is only enabled in the Aurora/Beta mozconfigs).

Is there a way we can land these mozconfig changes there without breaking these tests and having to hide them..?
I backed this out on Aurora and Beta for now:
https://hg.mozilla.org/releases/mozilla-aurora/rev/ff1c55497404
https://hg.mozilla.org/releases/mozilla-beta/rev/5c99a7357e6c

I'm still not sure of the best solution.  Maybe we could enable this only for "official" beta/release builds?
status-firefox11: fixed → affected
status-firefox12: fixed → affected
Whiteboard: [inbound]
(In reply to Matt Brubeck (:mbrubeck) from comment #22)
> This broke XUL Fennec browser-chrome tests and reftests on Aurora and Beta
> (but not on mozilla-central, probably because it is only enabled in the
> Aurora/Beta mozconfigs).
> 
> Is there a way we can land these mozconfig changes there without breaking
> these tests and having to hide them..?

how did this patch break them? if it is installing we should be fine.
(Assignee)

Updated

5 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Brad Lassey [:blassey] from comment #24)
> how did this patch break them? if it is installing we should be fine.

I have no idea why they broke, but browser-chrome and all crashtest and reftest suites went perma-orange with multiple failures:
https://tbpl.mozilla.org/?tree=Mozilla-Aurora&rev=ae27914c62ac
Created attachment 594265 [details] [diff] [review]
allow screen resizing - required for running reftests (1.0)
Attachment #594265 - Flags: review?(blassey.bugs)
(Assignee)

Updated

5 years ago
Attachment #594265 - Flags: review?(blassey.bugs) → review+
Created attachment 594402 [details] [diff] [review]
patch to include large screens in xul

Here's a try run with this patch, plus a patch to make try act like aurora and beta:
https://tbpl.mozilla.org/?tree=Try&rev=d2185388f15a
Attachment #594265 - Attachment is obsolete: true
Attachment #594402 - Flags: review?(mbrubeck)
try run is green
Comment on attachment 594402 [details] [diff] [review]
patch to include large screens in xul

Note that with this patch, 7" tablets will get XUL fennec from the Android Market, though they don't use the tablet layout.

(The most popular 7" tablets like the Kindle Fire and Nook Color don't use the Android Market anyway, so this change will affect a fairly small number of devices.)
Attachment #594402 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/e3bb8af42f98
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Does the above patch need to land elsewhere?
Comment on attachment 594402 [details] [diff] [review]
patch to include large screens in xul

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:
Attachment #594402 - Flags: approval-mozilla-beta?
Attachment #594402 - Flags: approval-mozilla-aurora?
Comment on attachment 594402 [details] [diff] [review]
patch to include large screens in xul

[Triage Comment]
Approved for Aurora 12 and Beta 11.
Attachment #594402 - Flags: approval-mozilla-beta?
Attachment #594402 - Flags: approval-mozilla-beta+
Attachment #594402 - Flags: approval-mozilla-aurora?
Attachment #594402 - Flags: approval-mozilla-aurora+
(Assignee)

Updated

5 years ago
Duplicate of this bug: 721551
https://hg.mozilla.org/releases/mozilla-beta/rev/610cfe719893
https://hg.mozilla.org/releases/mozilla-beta/rev/043d4b7d469d
status-firefox11: affected → fixed
(Assignee)

Updated

5 years ago
blocking-fennec1.0: --- → beta+
Blocks: 747531
Depends on: 752681
Depends on: 768613
You need to log in before you can comment on or make changes to this bug.