Need split builds for Fennec that serve XUL Fennec for tablets and native Fennec for phones

RESOLVED DUPLICATE of bug 719560

Status

()

Firefox for Android
General
P1
normal
RESOLVED DUPLICATE of bug 719560
5 years ago
3 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: mbrubeck)

Tracking

Trunk
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed, blocking-fennec1.0 beta+)

Details

(URL)

(Reporter)

Description

5 years ago
Catlee published a Fennec split build called  "SplitReleaseTest" from blassey on the Android Market.
The purpose of this split build was that it would serve XUL Fennec for tablets and native Fennec for phones.

While testing this, it gave a native Fennec build on my EEETransformer TF101. Mbrubeck also tested it on his Motorola Xoom and it also gave a native Fennec build. About:firefox gave 12.0a1 (2012-01-19).
(Reporter)

Comment 1

5 years ago
So afaik, we need a Fennec 11 split build that serves XUL Fennec for tablets and Native Fennec for phones, right?
Is there a new build planned that I would need to test on various devices (for which I would use DeviceAnywhere)?
Keywords: fennecnative-betablocker
(Reporter)

Comment 2

5 years ago
I guess it also might depend on which os is on the device.
(Assignee)

Updated

5 years ago
Assignee: nobody → mbrubeck
tracking-fennec: --- → ?
Priority: -- → P1
(Assignee)

Comment 3

5 years ago
I built native Fennec with the latest patch from 719560 and with a local patch to set MOZ_MOBILE_COMPAT=Phones in branding/unofficial/configure.sh.  When I upload it to the Market, the APK details say Supported screens: small-xlarge.  (It should be "small-large".)

So it looks like the manifest setting isn't working correctly, or isn't being read by the Market.  The AndroidManifest.xml file in my objdir does include <supports-screens android:xlargeScreens="false"/>, so at least my build seems to be working as expected...
(Assignee)

Comment 4

5 years ago
I tried adding android:resizeable="false" to the manifest but it made no difference.
(Assignee)

Comment 5

5 years ago
As far as I can tell, the Android Market can treat an APK as tablet-only, but not as phone-only.  Any app that supports small screens will also install on large-screen devices, and will just use zooming or letterboxing.
(Assignee)

Comment 6

5 years ago
http://developer.android.com/guide/appendix/market-filters.html#manifest-filters

"As a general rule, Market assumes that the platform on the device can adapt smaller layouts to larger screens, but cannot adapt larger layouts to smaller screens. Thus, if an application declares support for "normal" screen size only, Market makes the application available to both normal- and large-screen devices, but filters the application so that it is not available to small-screen devices."
(Assignee)

Comment 7

5 years ago
As a workaround, it looks like it might work if we make sure the XUL (tablet) build has a higher version code than the native (phone) build.  Testing this now.
(Assignee)

Comment 8

5 years ago
(In reply to Matt Brubeck (:mbrubeck) from comment #7)
> As a workaround, it looks like it might work if we make sure the XUL
> (tablet) build has a higher version code than the native (phone) build. 
> Testing this now.

This seems to work.  You can test this at:
https://market.android.com/details?id=org.mozilla.fennec_mbrubeck

Comment 9

5 years ago
(In reply to Matt Brubeck (:mbrubeck) from comment #8)
> (In reply to Matt Brubeck (:mbrubeck) from comment #7)
> > As a workaround, it looks like it might work if we make sure the XUL
> > (tablet) build has a higher version code than the native (phone) build. 
> > Testing this now.
> 
> This seems to work.  You can test this at:
> https://market.android.com/details?id=org.mozilla.fennec_mbrubeck

In a meeting, but i'll give this a spin on my tablet and devices in the next hour.  Matt, How long will you be leaving this up?
(Assignee)

Comment 10

5 years ago
Here are new builds that RelEng can use for Market testing:
https://people.mozilla.com/~mbrubeck/split/

The "xul.all.apk" build has a lower version code than the other two builds, and is marked compatible with all devices.  This can be used as a starting state for upgrade testing.

I'll leave my own market listing up for testing until RelEng is ready to create their own.  (Then I'll need to take mine down, if they want to use the same builds.)

I've tested this myself on HTC T-Mobile G2 (Android 2.3) and Motorola Xoom (Android 4).
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 11

5 years ago
I tested this on my EEETransformer TF101, there I get the XUL build and on my LG Optimus Black phone, it returns the native Fennec build. This is all correct.
On a 7 inch tablet, it should return the native Fennec build.
Naoki, I heard you have a HTC Flyer. Could you perhaps test the build with the link from comment 8?
(Assignee)

Comment 12

5 years ago
I tried this on my 7" Galaxy Tab (Android 2.3) and got the correct (native) build.
QA has also tested this on a few more devices, and so far, phones are serving up Native Fennec, and 10" tablets are serving up Fennec XUL.

I'd like to run one more test on a 7" HTC Flyer tonite before giving matt's build a blessing.   

As i understand this, 7" tablets should show the Fennec Native build.  

Naoki has this device, and will get to it this evening.

Matt, can you keep your build in the market a few more hours?   We'll let you know by email when to pull it down.
FYI, I commented in a different bug.  The Flyer will end up getting the native build.
(In reply to Tony Chung [:tchung] from comment #9)
> (In reply to Matt Brubeck (:mbrubeck) from comment #8)
> > (In reply to Matt Brubeck (:mbrubeck) from comment #7)
> > > As a workaround, it looks like it might work if we make sure the XUL
> > > (tablet) build has a higher version code than the native (phone) build. 
> > > Testing this now.
> > 
> > This seems to work.  You can test this at:
> > https://market.android.com/details?id=org.mozilla.fennec_mbrubeck
> 
> In a meeting, but i'll give this a spin on my tablet and devices in the next
> hour.  Matt, How long will you be leaving this up?

Matt, Feel free to pull it anytime we're ready.  We're done testing for now.
Is there anything that needs to land on Beta 11 here? Or does bug 719560 cover all remaining work?
(Assignee)

Comment 17

5 years ago
Nothing needed to land here.
status-firefox11: --- → fixed
Resolution: FIXED → DUPLICATE
Duplicate of bug: 719560
blocking-fennec1.0: --- → beta+
(Assignee)

Updated

5 years ago
Depends on: 760740
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.