Closed
Bug 719579
Opened 14 years ago
Closed 14 years ago
Force SQLite to use malloc_usable_size with jemalloc
Categories
(Core :: SQLite and Embedded Database Bindings, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
the newer version of SQLite tries to use _msize on Windows to replace the lack of malloc_usable_size.
For some reason when we build SQLite we end up not using the jemalloc version of _msize, and this causes heap assertions on Win64. I suspect some building order fancy due to the fact both libmozsqlite and libmozglue are shared and when building sqlite the compiler just see _msize as an extern.
Btw, we can tell SQLite that we have a proper malloc_usable_size function to use, so that it just goes through that.
|
Assignee | |
Updated•14 years ago
|
Blocks: SQLite3.7.10
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #589976 -
Flags: review?(sdwilsh)
|
|
Assignee | |
Updated•14 years ago
|
Summary: Force SQLite using malloc_usable_size when using jemalloc → Force SQLite to use malloc_usable_size with jemalloc
|
||
Comment 2•14 years ago
|
||
Comment on attachment 589976 [details] [diff] [review]
patch
Review of attachment 589976 [details] [diff] [review]:
-----------------------------------------------------------------
r=sdwilsh
Attachment #589976 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Flags: in-testsuite+
Target Milestone: --- → mozilla12
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•1 year ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•