Closed Bug 719579 Opened 8 years ago Closed 8 years ago

Force SQLite to use malloc_usable_size with jemalloc

Categories

(Toolkit :: Storage, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

the newer version of SQLite tries to use _msize on Windows to replace the lack of malloc_usable_size.
For some reason when we build SQLite we end up not using the jemalloc version of _msize, and this causes heap assertions on Win64. I suspect some building order fancy due to the fact both libmozsqlite and libmozglue are shared and when building sqlite the compiler just see _msize as an extern.

Btw, we can tell SQLite that we have a proper malloc_usable_size function to use, so that it just goes through that.
Blocks: SQLite3.7.10
Attached patch patchSplinter Review
Attachment #589976 - Flags: review?(sdwilsh)
Summary: Force SQLite using malloc_usable_size when using jemalloc → Force SQLite to use malloc_usable_size with jemalloc
Comment on attachment 589976 [details] [diff] [review]
patch

Review of attachment 589976 [details] [diff] [review]:
-----------------------------------------------------------------

r=sdwilsh
Attachment #589976 - Flags: review?(sdwilsh) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/65126f431e53
Flags: in-testsuite+
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/65126f431e53
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.