719850 - Web Console should be checked according to the selected tab

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Scoobidiver (away)]

When you open a Web Console in a tab, the Web Console menu is checked and stays checked as long as you haven't closed it.
When you switch to a tab without an open Web console, it should be unchecked.

Comment 1

[Rogério Gonçalves]

Attachment: Patch to this bug.

We verified the existence of a web console opened in current tab.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 590980 [details] [diff] [review]
Patch to this bug.

>+function onShowWebDeveloperMenu() {

please rename this to onWebDeveloperMenuShowing

>+  gBrowser.selectedTab.linkedBrowser.ownerDocument.getElementById("Tools:WebConsole").setAttribute("checked", HUDConsoleUI.getOpenHUD() != null);

'gBrowser.selectedTab.linkedBrowser.ownerDocument' is the same as 'document'

General approach looks good!

Comment 3

[Rogério Gonçalves]

Attachment: The second version to this bug reviewed by dao.

We made the suggested changes.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 591057 [details] [diff] [review]
The second version to this bug reviewed by dao.

thanks!

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1fe477ec35e9

Comment 6

[Dão Gottwald [:dao]]

landed a second time with the right author name:
http://hg.mozilla.org/integration/mozilla-inbound/rev/aa5578d6b29f

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aa5578d6b29f