Closed Bug 719850 Opened 10 years ago Closed 10 years ago

Web Console should be checked according to the selected tab

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 12

People

(Reporter: scoobidiver, Assigned: rogerio.rag)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

When you open a Web Console in a tab, the Web Console menu is checked and stays checked as long as you haven't closed it.
When you switch to a tab without an open Web console, it should be unchecked.
Assignee: nobody → rogerio.rag
Attached patch Patch to this bug. (obsolete) — Splinter Review
We verified the existence of a web console opened in current tab.
Attachment #590980 - Flags: review?(dao)
Comment on attachment 590980 [details] [diff] [review]
Patch to this bug.

>+function onShowWebDeveloperMenu() {

please rename this to onWebDeveloperMenuShowing

>+  gBrowser.selectedTab.linkedBrowser.ownerDocument.getElementById("Tools:WebConsole").setAttribute("checked", HUDConsoleUI.getOpenHUD() != null);

'gBrowser.selectedTab.linkedBrowser.ownerDocument' is the same as 'document'

General approach looks good!
Attachment #590980 - Flags: review?(dao) → review-
We made the suggested changes.
Attachment #590980 - Attachment is obsolete: true
Attachment #591057 - Flags: review?(dao)
Comment on attachment 591057 [details] [diff] [review]
The second version to this bug reviewed by dao.

thanks!
Attachment #591057 - Flags: review?(dao) → review+
Keywords: checkin-needed
landed a second time with the right author name:
http://hg.mozilla.org/integration/mozilla-inbound/rev/aa5578d6b29f
https://hg.mozilla.org/mozilla-central/rev/aa5578d6b29f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Duplicate of this bug: 721227
You need to log in before you can comment on or make changes to this bug.