The default bug view has changed. See this FAQ.

Web Console should be checked according to the selected tab

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Menus
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Scoobidiver (away), Assigned: Rogério Gonçalves)

Tracking

({regression})

Trunk
Firefox 12
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
When you open a Web Console in a tab, the Web Console menu is checked and stays checked as long as you haven't closed it.
When you switch to a tab without an open Web console, it should be unchecked.
(Assignee)

Updated

5 years ago
Assignee: nobody → rogerio.rag
(Assignee)

Comment 1

5 years ago
Created attachment 590980 [details] [diff] [review]
Patch to this bug.

We verified the existence of a web console opened in current tab.
Attachment #590980 - Flags: review?(dao)
Comment on attachment 590980 [details] [diff] [review]
Patch to this bug.

>+function onShowWebDeveloperMenu() {

please rename this to onWebDeveloperMenuShowing

>+  gBrowser.selectedTab.linkedBrowser.ownerDocument.getElementById("Tools:WebConsole").setAttribute("checked", HUDConsoleUI.getOpenHUD() != null);

'gBrowser.selectedTab.linkedBrowser.ownerDocument' is the same as 'document'

General approach looks good!
Attachment #590980 - Flags: review?(dao) → review-
(Assignee)

Comment 3

5 years ago
Created attachment 591057 [details] [diff] [review]
The second version to this bug reviewed by dao.

We made the suggested changes.
Attachment #590980 - Attachment is obsolete: true
Attachment #591057 - Flags: review?(dao)
Comment on attachment 591057 [details] [diff] [review]
The second version to this bug reviewed by dao.

thanks!
Attachment #591057 - Flags: review?(dao) → review+

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/1fe477ec35e9
Keywords: checkin-needed
Target Milestone: --- → Firefox 12
landed a second time with the right author name:
http://hg.mozilla.org/integration/mozilla-inbound/rev/aa5578d6b29f
https://hg.mozilla.org/mozilla-central/rev/aa5578d6b29f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Duplicate of this bug: 721227
You need to log in before you can comment on or make changes to this bug.