Closed Bug 719853 Opened 12 years ago Closed 12 years ago

MPL 2 upgrade: FlightDeck-selenium


( :: Licensing, task)

Not set


(Not tracked)



(Reporter: gerv, Assigned: gerv)




(1 file)

This bug tracks the MPL 2 upgrade for the project named in the subject line.
The repo is here:

Attached patch Patch v.1Splinter Review
Attachment #590219 - Flags: review?(zcampbell)
It looks like quite an improvement but I have two issues:

1. The mozwebqa.cfg file could possibly come under the trivial rule and not require the licence. It is just contains default command line parameters. I'm also not sure if this file can handle comments but I'll find out.

2. The script deletes our references to past contributors. We use this loosely for who worked on the file but also giving contributors recognition and we'd like to keep it.
If we need to have the licence in the file then mozwebqa.cfg will require a python-esque comment using #.
I don't mind too much about mozwebqa.cfg. I'll do something sensible :-)

With regard to the list of contributors, this issue was discussed in when the relicensing was being planned. It was decided that we would not retain contributor lists. These were not originally intended as a credit mechanism, and have not been consistently used as such. They were intended to track copyright owners, but were not good at that role either. So my relicensing script does not have code to identify and retain such lists (it just does a block replace of the licence), and it would be difficult and time-consuming to develop. :-|

There are existing and much higher-profile mechanisms within the project for making sure people get appropriate credit for their contributions to the project - primarily the "about:credits" window.

Good information, I agree it's inconsistent as a record of contributors. We will likely follow's decision. I'll talk to the team about a replacement for that.

In the meantime let's push through this patch in for FD with whatever change for the mozwebqa.cfg file.
This has been pull/merged, thanks :gerv.
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 590219 [details] [diff] [review]
Patch v.1

Review of attachment 590219 [details] [diff] [review]:

Attachment #590219 - Flags: review?(zcampbell) → review+
You need to log in before you can comment on or make changes to this bug.