719860 - Nothing happens when opening a .swf flash file directly

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Martijn Wargers (dead)]

You need to have the preference of Plugins set to "Tap to Play" to see this bug.

See url, nothing happens when loading that url.
I guess that since Flash is supported, the plugin placeholder should be shown, which you can then tap to play the Flash file.

Tested on the LG Optimus Black, Android 2.2.2.

Comment 1

[Martijn Wargers (dead)]

Actually, this is probably the same issue as bug 718983.

Comment 2

[:Margaret Leibovic]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #1)
> Actually, this is probably the same issue as bug 718983.

I agree. We follow a different code path for full-page plugins like this. Snorp, I can take this, since it's a click to play issue (and I'm already looking into bug 718983).

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Margaret Leibovic [:margaret] from comment #2)
> (In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #1)
> > Actually, this is probably the same issue as bug 718983.
> 
> I agree. We follow a different code path for full-page plugins like this.
> Snorp, I can take this, since it's a click to play issue (and I'm already
> looking into bug 718983).

Thanks!

Comment 5

[:Margaret Leibovic]

Attachment: patch

Disclaimer: This patch fixes the bug, but I'm not really sure why.

In bug 707886, my first patch busted full page plugin tests because we weren't automatically playing those plugins, and as a fix we decided to read the plugins.click_to_play pref in nsPluginHost::IsPluginEnabledForType to decide whether or not to automatically play those plugins. However, I'm not sure this was the right way to solve the bustage, since this patch implies that this call to IsPluginEnabledForType in nsContentDLF doesn't care if a plugin is click to play or not. I think that actually must be handled later, because with this patch applied and plugins.click_to_play set to true, you get the expected "Tap to play plugin" overlay UI.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 591336 [details] [diff] [review]
patch

Yeah, this looks right given the setup around this code.

Comment 7

[:Margaret Leibovic]

Landed on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d543ed92dcbd

Switching components, since this is a core issue that would affect desktop as well.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d543ed92dcbd

Comment 9

[:Margaret Leibovic]

Comment on attachment 591336 [details] [diff] [review]
patch

[Approval Request Comment]
With click to play plugins enabled, full page plugins don't work without this patch. Although this is core code, plugins.click_to_play is disabled on desktop, so this will not have any impact on desktop Firefox.

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 591336 [details] [diff] [review]
patch

[Triage Comment]
Near-zero risk to desktop. Approved for Aurora.

Comment 11

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e71036b16553