719928 - Graph Server: extract config.js from common.js and dashboard.js

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[Ryosuke Niwa]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.912.75 Safari/535.7

Comment 1

[Ryosuke Niwa]

Separate configurations specific to Mozilla so that WebKit port can use it without modifying common.js or dashboard.js.

Comment 2

[Ryosuke Niwa]

Attachment: Extracts config.js

Comment 3

[Robert Helmer [:rhelmer]]

There's a node.js script in scripts/static_graphs.js that we should move over, too.

Thanks for doing this, has been on my todo list forever :)

Comment 4

[Ryosuke Niwa]

(In reply to Robert Helmer [:rhelmer] from comment #3)
> There's a node.js script in scripts/static_graphs.js that we should move
> over, too.

As far as I know, static_graphs.js doesn't depend on common.js or dashboard.js. Or are you just saying that some configurations inside static_graphs.js should also be moved into config.js?

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to Ryosuke Niwa from comment #4)
> (In reply to Robert Helmer [:rhelmer] from comment #3)
> > There's a node.js script in scripts/static_graphs.js that we should move
> > over, too.
> 
> As far as I know, static_graphs.js doesn't depend on common.js or
> dashboard.js. Or are you just saying that some configurations inside
> static_graphs.js should also be moved into config.js?

Yeah let's leave that until later, really the node.js script should be refactored first to share more code, and we can worry about common configuration later.

Comment 6

[Robert Helmer [:rhelmer]]

Comment on attachment 590275 [details] [diff] [review]
Extracts config.js

https://github.com/mozilla/graphs/commit/c6476a76e7b39aa910cfeda82b910428bac31b16

Comment 7

[Robert Helmer [:rhelmer]]

Pushed to stage: http://graphs.allizom.org