Closed Bug 719931 Opened 13 years ago Closed 13 years ago

Refactor dashboard.js to prepare fetching dashboard manifest

Categories

(Webtools Graveyard :: Graph Server, defect)

Product:
Webtools Graveyard
Component:
Graph Server
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rniwa, Assigned: rniwa)

References

Details

Attachments

(1 file)

cleanup
8.46 KB, patch
rhelmer
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.912.75 Safari/535.7
Right now, dashboard.js initializes a bunch of variables and modifies DOM assuming that fetchDashboardManifest can return values synchronously. However, this is no longer the case when dashboard manifest is fetched by the server. We need to refactor the code so that fetchDashboardManifest can asynchronously return values.
Blocks: 718925
Depends on: 719928
Attached patch cleanup — — Splinter Review 

        Attachment #590406 -
        Flags: review?(rhelmer)

    
    

    
  
Comment on attachment 590406 [details] [diff] [review]
cleanup

Looks/works fine, going to make a few cosmetic changes before merging to make gjslint happy.

Thanks! :)

        Attachment #590406 -
        Flags: review?(rhelmer) → review+
Assignee: nobody → rniwa
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: