719990 - Failure in testSearch/testReorderSearchEngines.js | could not find element ID: dn

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

This failure occurs on Nightly only across all platforms.

([object Object],(void 0),(void 0),[object Object],(void 0))
@resource://mozmill/modules/controller.js:447 
([object Object])@resource://mozmill/modules/controller.js:495

Comment 1

[Alex Lakatos[:AlexLakatos]]

Attachment: patch v1.0 (default) [checked-in]

The down button changed id from "dn" to "down".

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Would be good to know which fixed regressed this test so we can add it to the dependency field.

Comment 3

[u279076]

Comment on attachment 590675 [details] [diff] [review]
patch v1.0 (default) [checked-in]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/1b403bffb3bd (default)

Comment 4

[u279076]

Alex, please verify this is fixed in tomorrow's testruns.

Comment 5

[Robert Kaiser]

(In reply to Alex Lakatos from comment #1)
> Created attachment 590675 [details] [diff] [review]
> patch v1.0 (default) [checked-in]
> 
> The down button changed id from "dn" to "down".

Bah, sorry I didn't catch this.

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Would be good to know which fixed regressed this test so we can add it to
> the dependency field.

All my fault. :(
Sorry.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Robert, no worries. We know that this can happen also because our tests aren't on mozilla-central.

Comment 7

[Robert Kaiser]

Ah, right. Wasn't sure where those tests are. After all, try and tbpl looked fine. ;-)

Comment 8

[u279076]

Verified fixed as no failures in today's testrun.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Robert, your fixes on bug 709589 shouldn't be part of Firefox 12, or? Some of our tests fail due to the 'dn' button is not available anymore.

http://mozmill-ondemand.blargon7.com/#/functional/report/deba2d9c92070b21ecef8d77262e1059

Alex, would you mind checking the RC of Firefox 12.0 and when a possible backport has happened?

I would propose we do not close bugs for now until we have real tracking flags for branches which I will request soon.

Comment 11

[Robert Kaiser]

(In reply to Henrik Skupin (:whimboo) from comment #10)
> Robert, your fixes on bug 709589 shouldn't be part of Firefox 12, or? Some
> of our tests fail due to the 'dn' button is not available anymore.

Parts of this bug landed for 12, one patch only for 13.

Attachment 580769 [details] [diff] which changed the button has landed for 12, from what I can see.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Robert Kaiser (:[e-mail]) from comment #11)
> Parts of this bug landed for 12, one patch only for 13.
> 
> Attachment 580769 [details] [diff] which changed the button has landed for
> 12, from what I can see.

Was that an accident? This attachment never got approval to land on the beta or now release branch.

Comment 13

[Robert Kaiser]

(In reply to Henrik Skupin (:whimboo) from comment #12)
> Was that an accident? This attachment never got approval to land on the beta
> or now release branch.

No accident. Just some patches landed on trunk before 12 went to aurora and one after that.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, so everything is fine. The reason why our tests failed is that Anthony run those before he merged the branches. So those results are invalid.

Anthony, for the future please make sure that we do the merge together with the source merge. Only that way we can also run our CI tests for candidate builds in the future.