Closed Bug 720142 Opened 9 years ago Closed 9 years ago

Use nsIntRect for table damage

Categories

(Core :: Layout: Tables, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: mats, Assigned: mats)

References

Details

Attachments

(3 files)

nsRect is for areas in app units and it uses nscoord which may not be
PRInt32 in the future.  We should propagate table damage using nsIntRect
to prevent mistakes and to make the code somewhat more future proof.
Arguably, we should a distinct type (eg TableDamageRect) to avoid the
mistake of passing a nsIntRect in pixel coordinates, but nsIntRect isn't
all that common on layout code so doesn't seem worth the effort right now.
Attachment #590490 - Flags: review?(bernd_mozilla)
Attachment #590491 - Flags: review?(bernd_mozilla)
Attachment #590492 - Flags: review?(bernd_mozilla)
That's all for this bug.
Attachment #590490 - Flags: review?(bernd_mozilla) → review+
Attachment #590491 - Flags: review?(bernd_mozilla) → review+
Attachment #590492 - Flags: review?(bernd_mozilla) → review+
You need to log in before you can comment on or make changes to this bug.