Use nsIntRect for table damage

RESOLVED FIXED in mozilla12

Status

()

defect
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

Trunk
mozilla12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Assignee

Description

8 years ago
nsRect is for areas in app units and it uses nscoord which may not be
PRInt32 in the future.  We should propagate table damage using nsIntRect
to prevent mistakes and to make the code somewhat more future proof.
Arguably, we should a distinct type (eg TableDamageRect) to avoid the
mistake of passing a nsIntRect in pixel coordinates, but nsIntRect isn't
all that common on layout code so doesn't seem worth the effort right now.
Assignee

Comment 1

8 years ago
Attachment #590490 - Flags: review?(bernd_mozilla)
Assignee

Comment 2

8 years ago
Attachment #590491 - Flags: review?(bernd_mozilla)
Assignee

Comment 3

8 years ago
Attachment #590492 - Flags: review?(bernd_mozilla)
Assignee

Comment 4

8 years ago
That's all for this bug.

Updated

8 years ago
Attachment #590490 - Flags: review?(bernd_mozilla) → review+

Updated

8 years ago
Attachment #590491 - Flags: review?(bernd_mozilla) → review+

Updated

8 years ago
Attachment #590492 - Flags: review?(bernd_mozilla) → review+
You need to log in before you can comment on or make changes to this bug.