720142 - Use nsIntRect for table damage

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Mats Palmgren (inactive)]

nsRect is for areas in app units and it uses nscoord which may not be
PRInt32 in the future.  We should propagate table damage using nsIntRect
to prevent mistakes and to make the code somewhat more future proof.
Arguably, we should a distinct type (eg TableDamageRect) to avoid the
mistake of passing a nsIntRect in pixel coordinates, but nsIntRect isn't
all that common on layout code so doesn't seem worth the effort right now.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Use nsIntRect for table damage.

Comment 2

[Mats Palmgren (inactive)]

Attachment: Only calculate the border half we actally use.

Comment 3

[Mats Palmgren (inactive)]

Attachment: Avoid calling GetFirstInFlow() on the row group twice.

Comment 4

[Mats Palmgren (inactive)]

That's all for this bug.

Comment 5

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67fb425e004b
https://hg.mozilla.org/integration/mozilla-inbound/rev/d65285b04917
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee922e0041e1

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/67fb425e004b
https://hg.mozilla.org/mozilla-central/rev/d65285b04917
https://hg.mozilla.org/mozilla-central/rev/ee922e0041e1