The default bug view has changed. See this FAQ.

Use nsIntRect for table damage

RESOLVED FIXED in mozilla12

Status

()

Core
Layout: Tables
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
nsRect is for areas in app units and it uses nscoord which may not be
PRInt32 in the future.  We should propagate table damage using nsIntRect
to prevent mistakes and to make the code somewhat more future proof.
Arguably, we should a distinct type (eg TableDamageRect) to avoid the
mistake of passing a nsIntRect in pixel coordinates, but nsIntRect isn't
all that common on layout code so doesn't seem worth the effort right now.
(Assignee)

Comment 1

5 years ago
Created attachment 590490 [details] [diff] [review]
Use nsIntRect for table damage.
Attachment #590490 - Flags: review?(bernd_mozilla)
(Assignee)

Comment 2

5 years ago
Created attachment 590491 [details] [diff] [review]
Only calculate the border half we actally use.
Attachment #590491 - Flags: review?(bernd_mozilla)
(Assignee)

Comment 3

5 years ago
Created attachment 590492 [details] [diff] [review]
Avoid calling GetFirstInFlow() on the row group twice.
Attachment #590492 - Flags: review?(bernd_mozilla)
(Assignee)

Comment 4

5 years ago
That's all for this bug.

Updated

5 years ago
Attachment #590490 - Flags: review?(bernd_mozilla) → review+

Updated

5 years ago
Attachment #590491 - Flags: review?(bernd_mozilla) → review+

Updated

5 years ago
Attachment #590492 - Flags: review?(bernd_mozilla) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/67fb425e004b
https://hg.mozilla.org/integration/mozilla-inbound/rev/d65285b04917
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee922e0041e1
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/67fb425e004b
https://hg.mozilla.org/mozilla-central/rev/d65285b04917
https://hg.mozilla.org/mozilla-central/rev/ee922e0041e1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Blocks: 1159990
You need to log in before you can comment on or make changes to this bug.