Last Comment Bug 720142 - Use nsIntRect for table damage
: Use nsIntRect for table damage
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout: Tables (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: Mats Palmgren (:mats)
:
:
Mentors:
Depends on:
Blocks: 1159990
  Show dependency treegraph
 
Reported: 2012-01-21 09:54 PST by Mats Palmgren (:mats)
Modified: 2015-04-29 19:11 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use nsIntRect for table damage. (60.13 KB, patch)
2012-01-21 10:03 PST, Mats Palmgren (:mats)
bernd_mozilla: review+
Details | Diff | Splinter Review
Only calculate the border half we actally use. (2.32 KB, patch)
2012-01-21 10:04 PST, Mats Palmgren (:mats)
bernd_mozilla: review+
Details | Diff | Splinter Review
Avoid calling GetFirstInFlow() on the row group twice. (1.69 KB, patch)
2012-01-21 10:04 PST, Mats Palmgren (:mats)
bernd_mozilla: review+
Details | Diff | Splinter Review

Description Mats Palmgren (:mats) 2012-01-21 09:54:44 PST
nsRect is for areas in app units and it uses nscoord which may not be
PRInt32 in the future.  We should propagate table damage using nsIntRect
to prevent mistakes and to make the code somewhat more future proof.
Arguably, we should a distinct type (eg TableDamageRect) to avoid the
mistake of passing a nsIntRect in pixel coordinates, but nsIntRect isn't
all that common on layout code so doesn't seem worth the effort right now.
Comment 1 Mats Palmgren (:mats) 2012-01-21 10:03:42 PST
Created attachment 590490 [details] [diff] [review]
Use nsIntRect for table damage.
Comment 2 Mats Palmgren (:mats) 2012-01-21 10:04:11 PST
Created attachment 590491 [details] [diff] [review]
Only calculate the border half we actally use.
Comment 3 Mats Palmgren (:mats) 2012-01-21 10:04:50 PST
Created attachment 590492 [details] [diff] [review]
Avoid calling GetFirstInFlow() on the row group twice.
Comment 4 Mats Palmgren (:mats) 2012-01-21 10:07:11 PST
That's all for this bug.

Note You need to log in before you can comment on or make changes to this bug.